Closed Bug 1264687 Opened 4 years ago Closed 3 years ago

[rep tests] Add tests for null rep

Categories

(DevTools :: Shared Components, enhancement, P1)

enhancement

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.2 - Jul 4
Tracking Status
firefox50 --- fixed

People

(Reporter: linclark, Assigned: linclark)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file, 2 obsolete files)

See Bug 1257552
Blocks: 1257552
Severity: normal → enhancement
Whiteboard: [devtools-html]
Flags: qe-verify-
Priority: -- → P2
Assignee: nobody → lclark
Priority: P2 → P1
Status: NEW → ASSIGNED
Iteration: --- → 49.1 - May 9
Assignee: lclark → nobody
Status: ASSIGNED → NEW
Iteration: 49.1 - May 9 → ---
Priority: P1 → P2
Assignee: nobody → lclark
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
Attached patch Bug1264687.patch (obsolete) — Splinter Review
Attachment #8764628 - Flags: review?(odvarko)
Attached patch Bug1264687.patch (obsolete) — Splinter Review
Removed unrelated comment
Attachment #8764628 - Attachment is obsolete: true
Attachment #8764628 - Flags: review?(odvarko)
Attachment #8764641 - Flags: review?(odvarko)
Comment on attachment 8764641 [details] [diff] [review]
Bug1264687.patch

Review of attachment 8764641 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Honza
Attachment #8764641 - Flags: review?(odvarko) → review+
Attached patch Bug1264687.patchSplinter Review
Rebased
Attachment #8764641 - Attachment is obsolete: true
Attachment #8766752 - Flags: review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/88250e019f25
[rep tests] Add tests for null rep. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/88250e019f25
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.