Closed Bug 1264688 Opened 3 years ago Closed 3 years ago

[rep tests] Add tests for number rep

Categories

(DevTools :: Shared Components, enhancement, P1)

enhancement

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.2 - Jul 4
Tracking Status
firefox50 --- fixed

People

(Reporter: linclark, Assigned: linclark)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file, 1 obsolete file)

See Bug 1257552
Blocks: 1257552
Severity: normal → enhancement
Whiteboard: [devtools-html]
Flags: qe-verify-
Priority: -- → P2
Assignee: nobody → lclark
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
Attached patch Bug1264688.patch (obsolete) — Splinter Review
If a grip comes back with the type -0, then I don't think it's handled... at least that's what the test seems to indicate. Honza, do you think this is an oversight, or is it intentional?
Flags: needinfo?(odvarko)
(In reply to Lin Clark [:linclark] from comment #1)
> Created attachment 8764717 [details] [diff] [review]
> Bug1264688.patch
> 
> If a grip comes back with the type -0, then I don't think it's handled...
True, I am seeing 'Object' instead of '-0'. It's a bug in Number.stringify()
Please file a bug I can fix it.

Honza
Flags: needinfo?(odvarko)
Blocks: 1283522
Attached patch Bug1264688.patchSplinter Review
Attachment #8766809 - Flags: review?(odvarko)
Attachment #8764717 - Attachment is obsolete: true
Comment on attachment 8766809 [details] [diff] [review]
Bug1264688.patch

Review of attachment 8766809 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and passes on my machine.

Please don't forget to file a bug related to wrong rendering of '-0'

Honza
Attachment #8766809 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/f0aae53c43a3
[rep tests] Add tests for number rep. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f0aae53c43a3
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.