Closed Bug 1264691 Opened 4 years ago Closed 3 years ago
[rep tests] Add tests for object-with-text rep
58 bytes, text/x-review-board-request
See Bug 1257552
Severity: normal → enhancement
This is a case where the console's output doesn't match the current state of the rep. For the test case, the console outputs: > CSSStyleRule ".Shadow" Where the rep outputs: > .Shadow I think the console's output is clearer, and it has a parallelism with the ObjectWithUrl output too. That can be discussed later when we are incorporating the reps into the console, though.
Attachment #8764548 - Flags: review?(odvarko)
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
Comment on attachment 8764548 [details] [diff] [review] Bug1264691.patch (In reply to Lin Clark [:linclark] from comment #1) > I think the console's output is clearer, and it has a parallelism with the > ObjectWithUrl output too. Agreed, I also like using type names in front of the value. Honza
Attachment #8764548 - Flags: review?(odvarko) → review+
needs rebasing, can you take a look ?
Rebased, so this should hopefully work now
Hi Lin, this still seems to have some problems like : 1 out of 1 hunks FAILED -- saving rejects to file devtools/client/shared/components/test/mochitest/chrome.ini.rej
Review commit: https://reviewboard.mozilla.org/r/61522/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/61522/
Attachment #8766741 - Flags: review?(odvarko)
Comment on attachment 8766741 [details] Bug 1264691 - [rep tests] Add tests for object-with-text rep. https://reviewboard.mozilla.org/r/61522/#review58370 Looks good! Honza
Attachment #8766741 - Flags: review?(odvarko) → review+
Attachment #8766335 - Attachment is obsolete: true
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/fx-team/rev/32c2569fd0e8 [rep tests] Add tests for object-with-text rep. r=Honza
You need to log in before you can comment on or make changes to this bug.