Closed
Bug 1264691
Opened 10 years ago
Closed 9 years ago
[rep tests] Add tests for object-with-text rep
Categories
(DevTools :: Shared Components, enhancement, P1)
DevTools
Shared Components
Tracking
(firefox50 fixed)
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: linclark, Assigned: linclark)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file, 2 obsolete files)
See Bug 1257552
|
||
Updated•10 years ago
|
Severity: normal → enhancement
Whiteboard: [devtools-html]
|
|
||
Updated•10 years ago
|
Blocks: devtools-html-2
|
|
||
Updated•10 years ago
|
Flags: qe-verify-
Priority: -- → P1
|
|
||
Updated•10 years ago
|
Priority: P1 → P2
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → lclark
|
|
Assignee | |
Comment 1•9 years ago
|
||
This is a case where the console's output doesn't match the current state of the rep.
For the test case, the console outputs:
> CSSStyleRule ".Shadow"
Where the rep outputs:
> .Shadow
I think the console's output is clearer, and it has a parallelism with the ObjectWithUrl output too. That can be discussed later when we are incorporating the reps into the console, though.
Attachment #8764548 -
Flags: review?(odvarko)
|
|
||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8764548 [details] [diff] [review]
Bug1264691.patch
(In reply to Lin Clark [:linclark] from comment #1)
> I think the console's output is clearer, and it has a parallelism with the
> ObjectWithUrl output too.
Agreed, I also like using type names in front of the value.
Honza
Attachment #8764548 -
Flags: review?(odvarko) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•9 years ago
|
||
Rebased, so this should hopefully work now
Attachment #8764548 -
Attachment is obsolete: true
Flags: needinfo?(lclark)
Attachment #8766335 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•9 years ago
|
||
Hi Lin, this still seems to have some problems like :
1 out of 1 hunks FAILED -- saving rejects to file devtools/client/shared/components/test/mochitest/chrome.ini.rej
Flags: needinfo?(lclark)
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/61522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61522/
Attachment #8766741 -
Flags: review?(odvarko)
|
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8766741 [details]
Bug 1264691 - [rep tests] Add tests for object-with-text rep.
https://reviewboard.mozilla.org/r/61522/#review58370
Looks good!
Honza
Attachment #8766741 -
Flags: review?(odvarko) → review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8766335 -
Attachment is obsolete: true
Flags: needinfo?(lclark)
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/32c2569fd0e8
[rep tests] Add tests for object-with-text rep. r=Honza
Keywords: checkin-needed
|
|
||
Comment 9•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
|
||
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•