Closed Bug 1264691 Opened 4 years ago Closed 3 years ago

[rep tests] Add tests for object-with-text rep

Categories

(DevTools :: Shared Components, enhancement, P1)

enhancement

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.2 - Jul 4
Tracking Status
firefox50 --- fixed

People

(Reporter: linclark, Assigned: linclark)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file, 2 obsolete files)

See Bug 1257552
Blocks: 1257552
Severity: normal → enhancement
Whiteboard: [devtools-html]
Flags: qe-verify-
Priority: -- → P1
Priority: P1 → P2
Assignee: nobody → lclark
Attached patch Bug1264691.patch (obsolete) — Splinter Review
This is a case where the console's output doesn't match the current state of the rep.

For the test case, the console outputs:

> CSSStyleRule ".Shadow"

Where the rep outputs:

> .Shadow

I think the console's output is clearer, and it has a parallelism with the ObjectWithUrl output too. That can be discussed later when we are incorporating the reps into the console, though.
Attachment #8764548 - Flags: review?(odvarko)
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
Comment on attachment 8764548 [details] [diff] [review]
Bug1264691.patch

(In reply to Lin Clark [:linclark] from comment #1)
> I think the console's output is clearer, and it has a parallelism with the
> ObjectWithUrl output too.
Agreed, I also like using type names in front of the value.

Honza
Attachment #8764548 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
needs rebasing, can you take a look ?
Flags: needinfo?(lclark)
Attached patch Bug1264681.patch (obsolete) — Splinter Review
Rebased, so this should hopefully work now
Attachment #8764548 - Attachment is obsolete: true
Flags: needinfo?(lclark)
Attachment #8766335 - Flags: review+
Keywords: checkin-needed
Hi Lin, this still seems to have some problems like :

1 out of 1 hunks FAILED -- saving rejects to file devtools/client/shared/components/test/mochitest/chrome.ini.rej
Flags: needinfo?(lclark)
Keywords: checkin-needed
Comment on attachment 8766741 [details]
Bug 1264691 - [rep tests] Add tests for object-with-text rep.

https://reviewboard.mozilla.org/r/61522/#review58370

Looks good!

Honza
Attachment #8766741 - Flags: review?(odvarko) → review+
Attachment #8766335 - Attachment is obsolete: true
Flags: needinfo?(lclark)
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/32c2569fd0e8
[rep tests] Add tests for object-with-text rep. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/32c2569fd0e8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.