Closed
Bug 1264695
Opened 9 years ago
Closed 9 years ago
[rep tests] Add tests for regexp rep
Categories
(DevTools :: Shared Components, enhancement, P1)
DevTools
Shared Components
Tracking
(firefox50 fixed)
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: linclark, Assigned: linclark)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file, 1 obsolete file)
See Bug 1257552
|
||
Updated•9 years ago
|
Severity: normal → enhancement
Whiteboard: [devtools-html]
|
|
||
Updated•9 years ago
|
Blocks: devtools-html-2
|
|
||
Updated•9 years ago
|
Flags: qe-verify-
Priority: -- → P2
|
Assignee | |
Comment 1•9 years ago
|
||
It seems as though the output is RegExp/ab+c/i. Is that intentional? In the console, it would be /ab+c/i.
Assignee: nobody → lclark
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)
Attachment #8764909 -
Flags: review?(odvarko)
|
|
||
Updated•9 years ago
|
Iteration: --- → 50.2
Priority: P2 → P1
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8764909 [details] [diff] [review]
Bug1264695.patch
Review of attachment 8764909 [details] [diff] [review]:
-----------------------------------------------------------------
(In reply to Lin Clark [:linclark] from comment #1)
> It seems as though the output is RegExp/ab+c/i. Is that intentional? In the
> console, it would be /ab+c/i.
We can remove it. It would be ok for me to do it as part of this bug report (e.g. as a second patch). I can't think of any place that would broke because of this change.
Honza
Attachment #8764909 -
Flags: review?(odvarko) → review+
|
|
||
Updated•9 years ago
|
Iteration: 50.2 - Jul 4 → 50.3 - Jul 18
|
|
Assignee | |
Comment 4•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/64254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64254/
Attachment #8770969 -
Flags: review?(odvarko)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8764909 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8770969 [details]
Bug 1264695 - [rep tests] Add tests for regexp rep.
https://reviewboard.mozilla.org/r/64254/#review61286
Carrying over r+
Attachment #8770969 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8770969 -
Flags: review?(odvarko)
|
|
Assignee | |
Comment 6•9 years ago
|
||
Comment on attachment 8770969 [details]
Bug 1264695 - [rep tests] Add tests for regexp rep.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64254/diff/1-2/
Attachment #8770969 -
Flags: review+ → review?(odvarko)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8770969 -
Flags: review?(odvarko)
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8770969 [details]
Bug 1264695 - [rep tests] Add tests for regexp rep.
https://reviewboard.mozilla.org/r/64254/#review61868
Attachment #8770969 -
Flags: review+
Pushed by lclark@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4879682a027d
[rep tests] Add tests for regexp rep. r=me
|
||
Comment 9•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•