1264698 - [rep tests] Add tests for stylesheet rep

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement, P1)

Description

[Lin Clark [:linclark]]

See Bug 1257552

Comment 1

[Lin Clark [:linclark]]

Attachment: Bug1264698.patch

The output for this is:

> StyleSheet styles.css

but in the console it would be:

> CSSStyleSheet http://example.com/styles.css

Whereas in Chrome it would be expandable, showing the actual stylesheet values

> CSSStyleSheet {ownerRule: null, cssRules: null, rules: null, type: "text/css", href: "https://abs.twimg.com/a/1466297184/css/t1/twitter_core.bundle.css"…}

For now, we can commit the test as is. Honza, do you have any opposition to changing to either of these two options later on?

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8764009 [details] [diff] [review]
Bug1264698.patch

Review of attachment 8764009 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Honza

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Lin Clark [:linclark] from comment #1)
> Created attachment 8764009 [details] [diff] [review]
> Bug1264698.patch
> 
> The output for this is:
> 
> > StyleSheet styles.css
> 
> but in the console it would be:
> 
> > CSSStyleSheet http://example.com/styles.css
> 
> Whereas in Chrome it would be expandable, showing the actual stylesheet
> values
> 
> > CSSStyleSheet {ownerRule: null, cssRules: null, rules: null, type: "text/css", href: "https://abs.twimg.com/a/1466297184/css/t1/twitter_core.bundle.css"…}
> 
> For now, we can commit the test as is. Honza, do you have any opposition to
> changing to either of these two options later on?

We could do:
* Tiny mode: StyleSheet styles.css - Used as an item in arrays or objects (styles.css has tooltip with full url).
* Short mode: CSSStyleSheet http://example.com/styles.css - Used in the DOM panel, Variables view.
* Long mode: CSSStyleSheet http://example.com/styles.css {ownerRule: null, cssRules: null, rules: null, …} - Used when logged in the Console panel.

Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/6ddb14d19d4d
[rep tests] Add tests for stylesheet rep. r=Honza

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ddb14d19d4d