Closed Bug 1264698 Opened 4 years ago Closed 4 years ago

[rep tests] Add tests for stylesheet rep

Categories

(DevTools :: Shared Components, enhancement, P1)

enhancement

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.2 - Jul 4
Tracking Status
firefox50 --- fixed

People

(Reporter: linclark, Assigned: linclark)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file)

See Bug 1257552
Blocks: 1257552
Severity: normal → enhancement
Whiteboard: [devtools-html]
Flags: qe-verify-
Priority: -- → P2
Assignee: nobody → lclark
Attached patch Bug1264698.patchSplinter Review
The output for this is:

> StyleSheet styles.css

but in the console it would be:

> CSSStyleSheet http://example.com/styles.css

Whereas in Chrome it would be expandable, showing the actual stylesheet values

> CSSStyleSheet {ownerRule: null, cssRules: null, rules: null, type: "text/css", href: "https://abs.twimg.com/a/1466297184/css/t1/twitter_core.bundle.css"…}

For now, we can commit the test as is. Honza, do you have any opposition to changing to either of these two options later on?
Attachment #8764009 - Flags: review?(odvarko)
Status: NEW → ASSIGNED
Iteration: --- → 50.1
Priority: P2 → P1
Iteration: 50.1 → 50.2
Comment on attachment 8764009 [details] [diff] [review]
Bug1264698.patch

Review of attachment 8764009 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

Honza
Attachment #8764009 - Flags: review?(odvarko) → review+
(In reply to Lin Clark [:linclark] from comment #1)
> Created attachment 8764009 [details] [diff] [review]
> Bug1264698.patch
> 
> The output for this is:
> 
> > StyleSheet styles.css
> 
> but in the console it would be:
> 
> > CSSStyleSheet http://example.com/styles.css
> 
> Whereas in Chrome it would be expandable, showing the actual stylesheet
> values
> 
> > CSSStyleSheet {ownerRule: null, cssRules: null, rules: null, type: "text/css", href: "https://abs.twimg.com/a/1466297184/css/t1/twitter_core.bundle.css"…}
> 
> For now, we can commit the test as is. Honza, do you have any opposition to
> changing to either of these two options later on?

We could do:
* Tiny mode: StyleSheet styles.css - Used as an item in arrays or objects (styles.css has tooltip with full url).
* Short mode: CSSStyleSheet http://example.com/styles.css - Used in the DOM panel, Variables view.
* Long mode: CSSStyleSheet http://example.com/styles.css {ownerRule: null, cssRules: null, rules: null, …} - Used when logged in the Console panel.

Honza
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/6ddb14d19d4d
[rep tests] Add tests for stylesheet rep. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6ddb14d19d4d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.