Closed
Bug 1264698
Opened 8 years ago
Closed 8 years ago
[rep tests] Add tests for stylesheet rep
Categories
(DevTools :: Shared Components, enhancement, P1)
DevTools
Shared Components
Tracking
(firefox50 fixed)
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: linclark, Assigned: linclark)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file)
2.81 KB,
patch
|
Honza
:
review+
|
Details | Diff | Splinter Review |
See Bug 1257552
Updated•8 years ago
|
Severity: normal → enhancement
Whiteboard: [devtools-html]
Updated•8 years ago
|
Blocks: devtools-html-2
Updated•8 years ago
|
Flags: qe-verify-
Priority: -- → P2
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → lclark
Assignee | ||
Comment 1•8 years ago
|
||
The output for this is: > StyleSheet styles.css but in the console it would be: > CSSStyleSheet http://example.com/styles.css Whereas in Chrome it would be expandable, showing the actual stylesheet values > CSSStyleSheet {ownerRule: null, cssRules: null, rules: null, type: "text/css", href: "https://abs.twimg.com/a/1466297184/css/t1/twitter_core.bundle.css"…} For now, we can commit the test as is. Honza, do you have any opposition to changing to either of these two options later on?
Attachment #8764009 -
Flags: review?(odvarko)
Updated•8 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 50.1
Priority: P2 → P1
Updated•8 years ago
|
Iteration: 50.1 → 50.2
Comment 2•8 years ago
|
||
Comment on attachment 8764009 [details] [diff] [review] Bug1264698.patch Review of attachment 8764009 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me! Honza
Attachment #8764009 -
Flags: review?(odvarko) → review+
Comment 3•8 years ago
|
||
(In reply to Lin Clark [:linclark] from comment #1) > Created attachment 8764009 [details] [diff] [review] > Bug1264698.patch > > The output for this is: > > > StyleSheet styles.css > > but in the console it would be: > > > CSSStyleSheet http://example.com/styles.css > > Whereas in Chrome it would be expandable, showing the actual stylesheet > values > > > CSSStyleSheet {ownerRule: null, cssRules: null, rules: null, type: "text/css", href: "https://abs.twimg.com/a/1466297184/css/t1/twitter_core.bundle.css"…} > > For now, we can commit the test as is. Honza, do you have any opposition to > changing to either of these two options later on? We could do: * Tiny mode: StyleSheet styles.css - Used as an item in arrays or objects (styles.css has tooltip with full url). * Short mode: CSSStyleSheet http://example.com/styles.css - Used in the DOM panel, Variables view. * Long mode: CSSStyleSheet http://example.com/styles.css {ownerRule: null, cssRules: null, rules: null, …} - Used when logged in the Console panel. Honza
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/fx-team/rev/6ddb14d19d4d [rep tests] Add tests for stylesheet rep. r=Honza
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6ddb14d19d4d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•