Closed Bug 1264700 Opened 4 years ago Closed 4 years ago

[rep tests] Add tests for undefined rep

Categories

(DevTools :: Shared Components, enhancement, P1)

enhancement

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Iteration:
49.1 - May 9
Tracking Status
firefox49 --- fixed

People

(Reporter: linclark, Assigned: linclark)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file, 1 obsolete file)

See Bug 1257552
Blocks: 1257552
Severity: normal → enhancement
Whiteboard: [devtools-html]
Assignee: nobody → lclark
Status: NEW → ASSIGNED
Iteration: --- → 49.1 - May 9
Flags: qe-verify-
Priority: -- → P1
Attached patch Bug1264700.patch (obsolete) — Splinter Review
Attachment #8747055 - Flags: review?(odvarko)
None of the ESLint issues seem to be related, so this is passing on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=46137e560b69&selectedJob=20158799
Comment on attachment 8747055 [details] [diff] [review]
Bug1264700.patch

Looks good to me!

The only comment I have is that we could also test the 'supportsObject' function (which is also exported from the undefined.js module).

Honza
Attachment #8747055 - Flags: review?(odvarko) → review+
Yeah, I thought about that. The `supportsObject` function gets tested implicitly by testing that the Rep chooses the correct object. I decided to do it this way to ensure that the chain of command was working properly. In cases where there is a more complicated `supportsObject` function, I will also test it explicitly.
Keywords: checkin-needed
Removing the checkin-needed keyword because this needs a fix based on the feedback in 1264692. It's not passing in the gripStub in the right way. It's only passing because undefined is the default.
Keywords: checkin-needed
One little thing, the <title> of the testing page says: Tree component test

Honza
Attached patch Bug1264692.patchSplinter Review
Thanks for catching that! I fixed that and the gripStub issue.
Attachment #8747055 - Attachment is obsolete: true
Attachment #8747789 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1d81e105d1f4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.