Closed Bug 1264700 Opened 4 years ago Closed 4 years ago
[rep tests] Add tests for undefined rep
See Bug 1257552
Severity: normal → enhancement
Status: NEW → ASSIGNED
Iteration: --- → 49.1 - May 9
Priority: -- → P1
None of the ESLint issues seem to be related, so this is passing on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=46137e560b69&selectedJob=20158799
Comment on attachment 8747055 [details] [diff] [review] Bug1264700.patch Looks good to me! The only comment I have is that we could also test the 'supportsObject' function (which is also exported from the undefined.js module). Honza
Attachment #8747055 - Flags: review?(odvarko) → review+
Yeah, I thought about that. The `supportsObject` function gets tested implicitly by testing that the Rep chooses the correct object. I decided to do it this way to ensure that the chain of command was working properly. In cases where there is a more complicated `supportsObject` function, I will also test it explicitly.
Removing the checkin-needed keyword because this needs a fix based on the feedback in 1264692. It's not passing in the gripStub in the right way. It's only passing because undefined is the default.
One little thing, the <title> of the testing page says: Tree component test Honza
Thanks for catching that! I fixed that and the gripStub issue.
You need to log in before you can comment on or make changes to this bug.