Closed Bug 1264701 Opened 4 years ago Closed 4 years ago

Move url utils to rep-utils.js

Categories

(DevTools :: Shared Components, enhancement, P1)

enhancement

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.3 - Jul 18
Tracking Status
firefox50 --- fixed

People

(Reporter: linclark, Assigned: gasolin)

References

Details

(Whiteboard: [reserve-html])

Attachments

(1 file)

See Bug 1257552
Blocks: 1257552
Severity: normal → enhancement
Whiteboard: [devtools-html]
Flags: qe-verify-
Priority: -- → P2
It turns out this isn't a rep. Honza, could these functions move to rep-utils? Or would you rather keep them in their own file?
Flags: needinfo?(odvarko)
Honza said it's ok to combine.
Flags: needinfo?(odvarko)
Summary: [rep tests] Add tests for url rep → Move url utils to rep-utils.js
Priority: P2 → P3
Whiteboard: [devtools-html] → [reserve-html]
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63612/diff/1-2/
Attachment #8769978 - Flags: review?(lclark)
The patch just combine url.js into rep-utils.js and change the related imports.
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;

https://reviewboard.mozilla.org/r/63612/#review60648

Looks like something went wrong in the copy-ing. The tests aren't passing.
Attachment #8769978 - Flags: review?(lclark) → review-
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63612/diff/2-3/
Attachment #8769978 - Flags: review- → review?(lclark)
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63612/diff/3-4/
https://reviewboard.mozilla.org/r/63612/#review60648

Thanks for review. The reason of build failure is because I forget to remove `url.js` from moz.build.
Update the patch and push a new try to see the result. Will ask review again once test passed.
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63612/diff/4-5/
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63612/diff/5-6/
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;

https://reviewboard.mozilla.org/r/63612/#review60994

LGTM, thanks!
Attachment #8769978 - Flags: review?(lclark) → review+
thanks!
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/12a9cf4fbb14
combine url utils to rep-utils.js; r=linclark
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/12a9cf4fbb14
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Iteration: --- → 50.3 - Jul 18
Priority: P3 → P1
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.