Closed Bug 1264774 Opened 5 years ago Closed 4 years ago

Connecting to irc://irc.w3.org:6665 using Chatzilla doesn't work anymore

Categories

(Other Applications :: ChatZilla, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: smaug, Assigned: bugzilla-mozilla-20000923)

References

Details

Attachments

(1 file)

See bug 1255386
looks like the irc protocol handler in chatzilla can choose to allow the use of a banned port through an existing interface and it should do so in this circumstance

https://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsIProtocolHandler.idl#113

also there is "network.security.ports.banned.override" for your local conf.. I've never seen it used  but its been in the code forever :)
oh, great. I need to try network.security.ports.banned.override for now.
I assume it is a string pref where I can just put 6665 as the only value (and if more ports, use ',' or ' ' between the ports.)
Looks like we (CZ) are already using the allowPort API... to block all banned ports.

http://hg.mozilla.org/chatzilla/file/a850d140b498/js/lib/chatzilla-service.js#l221

What kind of things would we need to consider before relaxing this?
(In reply to Patrick McManus [:mcmanus] from comment #1)
> also there is "network.security.ports.banned.override" for your local conf..
> I've never seen it used  but its been in the code forever :)
Thanks, that pref seems to work.
(In reply to James Ross from comment #3)
> Looks like we (CZ) are already using the allowPort API... to block all
> banned ports.
> 
> http://hg.mozilla.org/chatzilla/file/a850d140b498/js/lib/chatzilla-service.
> js#l221
> 
> What kind of things would we need to consider before relaxing this?

in the world of uris generated from arbitrary content, the concern is about content being able to explore ports generally protected behind a firewall (e.g. via xhr)..

you might just want to whitelist anything typically used with irc.
(In reply to Olli Pettay [:smaug] from comment #4)
> (In reply to Patrick McManus [:mcmanus] from comment #1)
> > also there is "network.security.ports.banned.override" for your local conf..
> > I've never seen it used  but its been in the code forever :)
> Thanks, that pref seems to work.

wouldn't be a good thing to have you not running nightly :)
Assignee: nobody → rginda
Component: Networking → ChatZilla
Product: Core → Other Applications
Version: 36 Branch → unspecified
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → Trunk
Apparently it's a Bugzilla thing to now prevent people requesting review when they're away. :(
Assignee: rginda → bugzilla-mozilla-20000923
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8785601 - Flags: review?
Attachment #8785601 - Flags: review? → review+
Flags: needinfo?(gijskruitbosch+bugs)
http://hg.mozilla.org/chatzilla/rev/e51fa71864f6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.