1264774 - Connecting to irc://irc.w3.org:6665 using Chatzilla doesn't work anymore

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

See bug 1255386

Comment 1

[Patrick McManus [:mcmanus]]

looks like the irc protocol handler in chatzilla can choose to allow the use of a banned port through an existing interface and it should do so in this circumstance

https://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsIProtocolHandler.idl#113

also there is "network.security.ports.banned.override" for your local conf.. I've never seen it used  but its been in the code forever :)

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

oh, great. I need to try network.security.ports.banned.override for now.
I assume it is a string pref where I can just put 6665 as the only value (and if more ports, use ',' or ' ' between the ports.)

Comment 3

[James Ross]

Looks like we (CZ) are already using the allowPort API... to block all banned ports.

http://hg.mozilla.org/chatzilla/file/a850d140b498/js/lib/chatzilla-service.js#l221

What kind of things would we need to consider before relaxing this?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Patrick McManus [:mcmanus] from comment #1)
> also there is "network.security.ports.banned.override" for your local conf..
> I've never seen it used  but its been in the code forever :)
Thanks, that pref seems to work.

Comment 5

[Patrick McManus [:mcmanus]]

(In reply to James Ross from comment #3)
> Looks like we (CZ) are already using the allowPort API... to block all
> banned ports.
> 
> http://hg.mozilla.org/chatzilla/file/a850d140b498/js/lib/chatzilla-service.
> js#l221
> 
> What kind of things would we need to consider before relaxing this?

in the world of uris generated from arbitrary content, the concern is about content being able to explore ports generally protected behind a firewall (e.g. via xhr)..

you might just want to whitelist anything typically used with irc.

Comment 6

[Patrick McManus [:mcmanus]]

(In reply to Olli Pettay [:smaug] from comment #4)
> (In reply to Patrick McManus [:mcmanus] from comment #1)
> > also there is "network.security.ports.banned.override" for your local conf..
> > I've never seen it used  but its been in the code forever :)
> Thanks, that pref seems to work.

wouldn't be a good thing to have you not running nightly :)

Comment 7

[James Ross]

Attachment: Allow all ports for irc: and ircs:

Apparently it's a Bugzilla thing to now prevent people requesting review when they're away. :(

Comment 8

[James Ross]

http://hg.mozilla.org/chatzilla/rev/e51fa71864f6