1264869 - Image download fails after accepting STORAGE permission

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

From bug 1240710 comment 32: Trying to download an image shows the permission prompt for STORAGE but the download still fails after accepting.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1264869 - Request STORAGE permission before downloading images. r?liuche

Review commit: https://reviewboard.mozilla.org/r/46735/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46735/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

With this patch we ask for the permission before downloading the image. We don't need the fanciness of bug 1240710 here, where we start the download before we actually have the permission.

Let's uplift this all the way up to 46 - if it's not too late.

Comment 3

[Chenxia Liu [:liuche]]

Comment on attachment 8741756 [details]
MozReview Request: Bug 1264869 - Request STORAGE permission before downloading images. r?liuche

https://reviewboard.mozilla.org/r/46735/#review43375

This looks good! I looked around for some other places where we might have to do waitForPermissions and didn't find any, so that seems good.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/1a103681b59fd604cdfa9fded1e4ff2eae68282f
Bug 1264869 - Request STORAGE permission before downloading images. r=liuche

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8741756 [details]
MozReview Request: Bug 1264869 - Request STORAGE permission before downloading images. r?liuche

Approval Request Comment

[Feature/regressing bug #]: Runtime permissions - Introduced with Firefox 46.0 - Bug 1212830. Maybe it's too late for 46, but requesting uplift anyways.

[User impact if declined]: When downloading an image (without STORAGE permission) then we prompt for the permission but even after accepting the permission the download will fail. All subsequent downloads will be successful though.

[Describe test coverage new/current, TreeHerder]: Local testing.

[Risks and why]: Low risk. Wrapped call in existing code for permission check.

[String/UUID change made/needed]: -

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8741756 [details]
MozReview Request: Bug 1264869 - Request STORAGE permission before downloading images. r?liuche

[Triage Comment]

We want image download to work, this sounds like a major regression in 46 to me.  Let's take this for aurora, beta, and m-r please.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Asking for QE verification once this lands.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1a103681b59f

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/29e500802b47

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-release/rev/cb81505286e1351e2665a8ccaa08c222bc38423b
https://hg.mozilla.org/releases/mozilla-beta/rev/0821a5eeb05c5f79c7c71ab40baa9473b2884927

Comment 11

[u421692]

Verified as fixed on Firefox 46 Beta 13 on Nexus 6 (Android 6.0.1)

Comment 12

[u421692]

Verified as fixed on Firefox 46 RC on Nexus 9 (Android 6.0.1)

Comment 13

[Alexandru Simonca [:asimonca], Release Desktop QA]

Verified as fixed on Firefox 48.0a2 (2016-05-23) and on Firefox Beta 47.0b6 on Nexus 6 (Android 6.0)

Comment 14

[Stefan Deiac]

Based on previous comments I will remove the qe-verify flag.