Closed Bug 1264869 Opened 8 years ago Closed 8 years ago

Image download fails after accepting STORAGE permission

Categories

(Firefox for Android Graveyard :: Download Manager, defect)

46 Branch
All
Android
defect
Not set
normal

Tracking

(firefox45 unaffected, firefox46+ verified, firefox47+ verified, firefox48+ verified)

VERIFIED FIXED
Firefox 48
Tracking Status
firefox45 --- unaffected
firefox46 + verified
firefox47 + verified
firefox48 + verified

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

(Keywords: regression)

Attachments

(1 file)

From bug 1240710 comment 32: Trying to download an image shows the permission prompt for STORAGE but the download still fails after accepting.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
With this patch we ask for the permission before downloading the image. We don't need the fanciness of bug 1240710 here, where we start the download before we actually have the permission.

Let's uplift this all the way up to 46 - if it's not too late.
Comment on attachment 8741756 [details]
MozReview Request: Bug 1264869 - Request STORAGE permission before downloading images. r?liuche

https://reviewboard.mozilla.org/r/46735/#review43375

This looks good! I looked around for some other places where we might have to do waitForPermissions and didn't find any, so that seems good.
Attachment #8741756 - Flags: review?(liuche) → review+
Comment on attachment 8741756 [details]
MozReview Request: Bug 1264869 - Request STORAGE permission before downloading images. r?liuche

Approval Request Comment

[Feature/regressing bug #]: Runtime permissions - Introduced with Firefox 46.0 - Bug 1212830. Maybe it's too late for 46, but requesting uplift anyways.

[User impact if declined]: When downloading an image (without STORAGE permission) then we prompt for the permission but even after accepting the permission the download will fail. All subsequent downloads will be successful though.

[Describe test coverage new/current, TreeHerder]: Local testing.

[Risks and why]: Low risk. Wrapped call in existing code for permission check.

[String/UUID change made/needed]: -
Attachment #8741756 - Flags: approval-mozilla-beta?
Attachment #8741756 - Flags: approval-mozilla-aurora?
Keywords: regression
Comment on attachment 8741756 [details]
MozReview Request: Bug 1264869 - Request STORAGE permission before downloading images. r?liuche

[Triage Comment]

We want image download to work, this sounds like a major regression in 46 to me.  Let's take this for aurora, beta, and m-r please.
Attachment #8741756 - Flags: approval-mozilla-release+
Attachment #8741756 - Flags: approval-mozilla-beta?
Attachment #8741756 - Flags: approval-mozilla-beta+
Attachment #8741756 - Flags: approval-mozilla-aurora?
Attachment #8741756 - Flags: approval-mozilla-aurora+
Asking for QE verification once this lands.
Flags: qe-verify+
https://hg.mozilla.org/mozilla-central/rev/1a103681b59f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Verified as fixed on Firefox 46 Beta 13 on Nexus 6 (Android 6.0.1)
Verified as fixed on Firefox 46 RC on Nexus 9 (Android 6.0.1)
Verified as fixed on Firefox 48.0a2 (2016-05-23) and on Firefox Beta 47.0b6 on Nexus 6 (Android 6.0)
Status: RESOLVED → VERIFIED
Version: unspecified → 46 Branch
Based on previous comments I will remove the qe-verify flag.
Flags: qe-verify+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.