1265099 - Permission snackbar prompt to allow storage access cropped

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: storage permission prompt cropped.png

Firefox for Android 47.0a2 20160415, Sony Z3 Compact with Android 6.0.1

See the attached screenshot. The snack bar prompt requesting permission to the storage to e.g. save updates is cropped in English and more badly in some locales.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Mhmh, smaller screen, I guess our only option is to use a shorter string?

We only show this Snackbar on Nightly and Aurora. So I am less concerned about cutting it off.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Or: We remove the Snackbar completely. The reason we show it is that on Aurora/Nightly we need the permission for our custom updater. However in the case an update is available but can't be downloaded because of the permission, we already show a notification.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Sebastian Kaspari (:sebastian) from comment #2)
> Or: We remove the Snackbar completely. The reason we show it is that on
> Aurora/Nightly we need the permission for our custom updater. However in the
> case an update is available but can't be downloaded because of the
> permission, we already show a notification.

If it's really that important, can't we put this in a dialog? That way, there's no way a user can miss the prompt. 

We could even keep the same copy.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

If you have control of the layout, can you increase the line count e.g. by decreasing the padding?

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Anthony Lam (:antlam) from comment #3)
> If it's really that important, can't we put this in a dialog? That way,
> there's no way a user can miss the prompt. 

A dialog is super annoying and in-your-face. I'd rather push for removing the snackbar completely and only using the notification (see comment 2).


(In reply to Sebastian H. [:aryx][:archaeopteryx] from comment #4)
> If you have control of the layout, can you increase the line count e.g. by
> decreasing the padding?

We are using a component from the support library that is following the guidelines very strictly:
https://www.google.com/design/spec/components/snackbars-toasts.html#snackbars-toasts-usage

The snackbar is not really made for long texts:

> Very short text strings
> Snackbars should contain a single line of text directly related to the operation performed.
> They may contain a text action. They cannot contain icons.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.