Closed Bug 1265311 Opened 3 years ago Closed 3 years ago

Add more proxy functions to MediaDecoderReaderWrapper

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

So that MDSM can depend solely on MediaDecoderReaderWrapper without referencing to both MediaDecoderReader and MediaDecoderReaderWrapper.
Blocks: 1265315
Blocks: 1265634
Comment on attachment 8742380 [details]
MozReview Request: Bug 1265311 - Add more proxy functions to MediaDecoderReaderWrapper. r=jya.

https://reviewboard.mozilla.org/r/47173/#review44085

::: dom/media/MediaDecoderReaderWrapper.h:58
(Diff revision 1)
> +  void ReleaseMediaResources();
> +  void SetIdle();
> +  void ResetDecode();
> +
> +  nsresult Init() { return mReader->Init(); }
> +  bool IsWaitForDataSupported() { return mReader->IsWaitForDataSupported(); }

cant this be made const too ?

::: dom/media/MediaDecoderReaderWrapper.h:60
(Diff revision 1)
> +  void ResetDecode();
> +
> +  nsresult Init() { return mReader->Init(); }
> +  bool IsWaitForDataSupported() { return mReader->IsWaitForDataSupported(); }
> +  bool IsAsync() const { return mReader->IsAsync(); }
> +  bool UseBufferingHeuristics() { return mReader->UseBufferingHeuristics(); }

cant this be made const too ?
Attachment #8742380 - Flags: review?(jyavenard) → review+
Thanks! I will add another patch to constify those functions.
Bug 1265311. Part 2 - constify some functions. r=jya.
Attachment #8742676 - Flags: review?(jyavenard)
Attachment #8742676 - Flags: review?(jyavenard) → review+
Thanks!
https://hg.mozilla.org/mozilla-central/rev/0220fd37d605
https://hg.mozilla.org/mozilla-central/rev/d5d46a4ad2be
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.