1265311 - Add more proxy functions to MediaDecoderReaderWrapper

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

So that MDSM can depend solely on MediaDecoderReaderWrapper without referencing to both MediaDecoderReader and MediaDecoderReaderWrapper.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb39101fb52d

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1265311 - Add more proxy functions to MediaDecoderReaderWrapper. r=jya.

Review commit: https://reviewboard.mozilla.org/r/47173/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47173/

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8742380 [details]
MozReview Request: Bug 1265311 - Add more proxy functions to MediaDecoderReaderWrapper. r=jya.

https://reviewboard.mozilla.org/r/47173/#review44085

::: dom/media/MediaDecoderReaderWrapper.h:58
(Diff revision 1)
> +  void ReleaseMediaResources();
> +  void SetIdle();
> +  void ResetDecode();
> +
> +  nsresult Init() { return mReader->Init(); }
> +  bool IsWaitForDataSupported() { return mReader->IsWaitForDataSupported(); }

cant this be made const too ?

::: dom/media/MediaDecoderReaderWrapper.h:60
(Diff revision 1)
> +  void ResetDecode();
> +
> +  nsresult Init() { return mReader->Init(); }
> +  bool IsWaitForDataSupported() { return mReader->IsWaitForDataSupported(); }
> +  bool IsAsync() const { return mReader->IsAsync(); }
> +  bool UseBufferingHeuristics() { return mReader->UseBufferingHeuristics(); }

cant this be made const too ?

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks! I will add another patch to constify those functions.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1265311_part2_constify_some_functions.patch

Bug 1265311. Part 2 - constify some functions. r=jya.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0220fd37d605
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5d46a4ad2be

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0220fd37d605
https://hg.mozilla.org/mozilla-central/rev/d5d46a4ad2be