1265315 - Remove dependency on MediaDecoderReader from SeekTask

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

After fixing bug 1265311, SeekTask will be able to depend solely on MediaDecoderReaderWrapper without referencing MediaDecoderReader.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=337ce62b8bc3

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1265315. Part 1 - remove use of MediaDecoderReader from SeekTask. r=kaku.

Review commit: https://reviewboard.mozilla.org/r/47177/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47177/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1265315. Part 2 - rename mReaderWrapper to mReader for less verbose coding. r=kaku.

Review commit: https://reviewboard.mozilla.org/r/47179/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/47179/

Comment 4

[Tzuhao Kuo [:kaku]]

Comment on attachment 8742382 [details]
MozReview Request: Bug 1265315. Part 2 - rename mReaderWrapper to mReader for less verbose coding. r=kaku.

https://reviewboard.mozilla.org/r/47179/#review44033

Comment 5

[Tzuhao Kuo [:kaku]]

Comment on attachment 8742381 [details]
MozReview Request: Bug 1265315. Part 1 - remove use of MediaDecoderReader from SeekTask. r=kaku.

https://reviewboard.mozilla.org/r/47177/#review44031

::: dom/media/SeekTask.h
(Diff revision 1)
>  
>  #ifndef SEEK_TASK_H
>  #define SEEK_TASK_H
>  
>  #include "mozilla/MozPromise.h"
> -#include "MediaDecoderReader.h"

I think we still need to include this header for the definitions of:
MediaDecoderReader::SeekPromise
MediaDecoderReader::AudioDataPromise
MediaDecoderReader::VideoDataPromise
MediaDecoderReader::WaitForDataPromise

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

https://reviewboard.mozilla.org/r/47177/#review44031

> I think we still need to include this header for the definitions of:
> MediaDecoderReader::SeekPromise
> MediaDecoderReader::AudioDataPromise
> MediaDecoderReader::VideoDataPromise
> MediaDecoderReader::WaitForDataPromise

Somehow I didn't get compile errors in non-unified build. However, it makes sense to include "MediaDecoderReader.h".

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ba90ff27748
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fcee6752011

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1ba90ff27748
https://hg.mozilla.org/mozilla-central/rev/0fcee6752011