Closed
Bug 1265315
Opened 8 years ago
Closed 8 years ago
Remove dependency on MediaDecoderReader from SeekTask
Categories
(Core :: Audio/Video: Playback, defect, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(2 files)
After fixing bug 1265311, SeekTask will be able to depend solely on MediaDecoderReaderWrapper without referencing MediaDecoderReader.
Assignee | ||
Comment 1•8 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=337ce62b8bc3
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/47177/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/47177/
Attachment #8742381 -
Flags: review?(tkuo)
Attachment #8742382 -
Flags: review?(tkuo)
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/47179/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/47179/
Updated•8 years ago
|
Priority: -- → P2
Updated•8 years ago
|
Attachment #8742382 -
Flags: review?(tkuo) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8742382 [details] MozReview Request: Bug 1265315. Part 2 - rename mReaderWrapper to mReader for less verbose coding. r=kaku. https://reviewboard.mozilla.org/r/47179/#review44033
Comment 5•8 years ago
|
||
Comment on attachment 8742381 [details] MozReview Request: Bug 1265315. Part 1 - remove use of MediaDecoderReader from SeekTask. r=kaku. https://reviewboard.mozilla.org/r/47177/#review44031 ::: dom/media/SeekTask.h (Diff revision 1) > > #ifndef SEEK_TASK_H > #define SEEK_TASK_H > > #include "mozilla/MozPromise.h" > -#include "MediaDecoderReader.h" I think we still need to include this header for the definitions of: MediaDecoderReader::SeekPromise MediaDecoderReader::AudioDataPromise MediaDecoderReader::VideoDataPromise MediaDecoderReader::WaitForDataPromise
Attachment #8742381 -
Flags: review?(tkuo) → review+
Assignee | ||
Comment 6•8 years ago
|
||
https://reviewboard.mozilla.org/r/47177/#review44031 > I think we still need to include this header for the definitions of: > MediaDecoderReader::SeekPromise > MediaDecoderReader::AudioDataPromise > MediaDecoderReader::VideoDataPromise > MediaDecoderReader::WaitForDataPromise Somehow I didn't get compile errors in non-unified build. However, it makes sense to include "MediaDecoderReader.h".
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ba90ff27748 https://hg.mozilla.org/integration/mozilla-inbound/rev/0fcee6752011
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1ba90ff27748 https://hg.mozilla.org/mozilla-central/rev/0fcee6752011
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•