1265327 - Event popup's "Open in Debugger" does not jump to correct file for source mapped (minified) js files

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Jens]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160407164938

Steps to reproduce:

1. Open Devtools
2. Go to a page which uses minified JS with a source map
3. Hover over a DOM node which has an JS event attached
4. Click on the "ev" button to see the event popup
5. Click on "Open in Debugger"


Actual results:

Jumps to the last open file and position in Debugger panel.


Expected results:

Jump to the correct line in correct file for the function shown in the event popup

Comment 1

[Julian Descottes [:jdescottes]]

Inspector bug triage. Filter on CLIMBING SHOES.
If the inspector makes you jump to a wrong file this is pretty bad.
Feature is broken -> P2

ni? myself to verify the bug

Comment 2

[Tom Tromey :tromey]

I'm fixing source-maps in the event popup in bug 1361853.

Comment 3

[Tom Tromey :tromey]

Sorry, wrong bug.

Comment 4

[:Harald Kirschner :digitarald]

Looks like it was duped by accident and never re-opened. Mike; could you help here to confirm if the work is in Debugger or the Inspector? It is important to finally get to a good level of source maps and this issue keeps popping up in feedback and breaks the smooth interplay between panels.

Martin, we are still confirming if this is an issue in the Debugger or Inspector – but would this make a good bug for the quality backlog?

Comment 5

[Martin Balfanz [:mbalfanz]]

Agreed, I added it to the backlog. Though if it's not an inspector bug we may remove it again from there.

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Tom fixed this in bug 1333352 and it works just fine now.

Comment 7

[:Harald Kirschner :digitarald]

Attachment: image.png

Mike, can you confirm where this would work?

This is not working for me on sites with source maps, send.firefox.com, reddit.com or github.com . All events link to the same file and position; even though the event handler inline preview shows the correct handler source.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to :Harald Kirschner :digitarald from comment #7)

Created attachment 9051776 [details]
image.png

Mike, can you confirm where this would work?

This is not working for me on sites with source maps, send.firefox.com, reddit.com or github.com . All events link to the same file and position; even though the event handler inline preview shows the correct handler source.

It seems like we at the very least have edge cases... re-opening.

Comment 9

[:Harald Kirschner :digitarald]

Made a simpler test case: https://amusing-dove.glitch.me/

STR:

1. Open Devtools
2. Inspect the first button which has an JS event attached
3. Click on the "ev" button to see the event popup
4. Click on "Open in Debugger" icon

I am unsure about this having just edge cases. I have not seen it working for any source mapped case.

Comment 10

[:Harald Kirschner :digitarald]

To clarify:

Inline code preview in the events panel works and shows the correct handler. Resolving the filename and location works and shows the original location.

Clicking the link to the Debugger is what isn't working and send to the wrong file (generated file instead of original) with the correct original location. In the example, the original location of index.js:13 jumps to the generated file client.js:13.

Comment 11

[Logan Smyth [:loganfsmyth]]

I'm going to close this in favor of https://bugzilla.mozilla.org/show_bug.cgi?id=1538397 since this seems like a new regression separate from the older issue.