1361853 - switch network monitor to use client-side source map service

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Tom Tromey :tromey]

The network monitor should use the client-side source map service to handle
source maps for its stack traces.
This is similar to bug 1306261, but I think that one is specific to the old
network panel implementation.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Just a note that the Net monitor is displaying the stack trace in a side panel and the corresponding code is here:
http://searchfox.org/mozilla-central/rev/b0e1da2a90ada7e00f265838a3fafd00af33e547/devtools/client/netmonitor/src/components/stack-trace-panel.js#23

(it's based on shared StackTrace component (devtools/client/shared/components/stack-trace)

Honza

Comment 2

[Tom Tromey :tromey]

I'm going to the attach the patch momentarily.
I would appreciate a review, but it can't be put in until bug 1317962 re-lands.

Comment 3

[Tom Tromey :tromey]

Attachment: Bug 1361853 - use client-side source map service in network monitor;

Review commit: https://reviewboard.mozilla.org/r/138586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138586/

Comment 5

[Tom Tromey :tromey]

Bug 1317962 landed (hopefully will stick this time), so I rebased.
Rebasing had a conflict, so I'm attaching the new version.

Comment 6

[Tom Tromey :tromey]

Comment on attachment 8866991 [details]
Bug 1361853 - use client-side source map service in network monitor;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138586/diff/1-2/

Comment 7

[Tom Tromey :tromey]

Comment on attachment 8866991 [details]
Bug 1361853 - use client-side source map service in network monitor;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138586/diff/2-3/

Comment 8

[Tom Tromey :tromey]

Also update the test...

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8866991 [details]
Bug 1361853 - use client-side source map service in network monitor;

https://reviewboard.mozilla.org/r/138586/#review145484

Looks great to me, thanks for working on this Tom!

Honza

Comment 10

[Tom Tromey :tromey]

Updating for eslint.

Comment 11

[Tom Tromey :tromey]

Comment on attachment 8866991 [details]
Bug 1361853 - use client-side source map service in network monitor;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138586/diff/3-4/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec3dbc16d7bb
use client-side source map service in network monitor; r=Honza

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ec3dbc16d7bb