Closed
Bug 1265383
Opened 9 years ago
Closed 9 years ago
Offer to set home page if the home page is unset.
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jhugman, Assigned: jhugman)
References
Details
Attachments
(1 file)
The first time the home page button is tapped, then we should offer to set the home page.
https://docs.google.com/document/d/1AC28wspOVC-yNo2B1iBmrddMPBLF0tmS3T7XabKYxb4/edit
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jhugman
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•9 years ago
|
||
Functionally, this PR works, almost exactly as designed, although the code does not yet use AppState.
Making it work via AppState will not only add to the code in this PR, so I'd like to merge this into the feature branch so I can work on long pressing (which depends on this bug), without being blocked on AppState.
Filing an additional bug (Bug 1265389) to make this work with AppState.
Attachment #8748724 -
Flags: review?(sleroux)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8748724 [details] [review]
Pull request
I think it's good just not sure about the UIAlertAction's closures and retain cycles.
Attachment #8748724 -
Flags: feedback+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Address nits, and answered question on possible retain cycle. https://github.com/mozilla/firefox-ios/pull/1774#discussion_r62326293
|
|
||
Updated•9 years ago
|
Attachment #8748724 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Merged into https://github.com/mozilla/firefox-ios/pull/1772 and closed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•