1265389 - Promote the home page button to a more prominent place for Chinese users

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[James Hugman [:jhugman] [@jhugman]]

The biggest driver for the home page button to enable portal pages for markets where typing URLs is difficult (e.g. China).

https://docs.google.com/document/d/1AC28wspOVC-yNo2B1iBmrddMPBLF0tmS3T7XabKYxb4/edit

For Chinese markets, the home page and share buttons should be transposed.

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1817

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Attachment: Simulator Screen Shot May 16, 2016, 3.36.03 PM.png

I think I'm missing a number of icons:

shareMenu-pbm shareMenu-Engaged
bottomNav-HomePage

Screenshot shows homepage button in URL bar in private browsing mode with menu open.

Comment 3

[Robin Andersen [:tecgirl]]

(In reply to James Hugman [:jhugman] [@jhugman] from comment #2)
> Created attachment 8752861 [details]
> Simulator Screen Shot May 16, 2016, 3.36.03 PM.png
> 
> I think I'm missing a number of icons:
> 
> shareMenu-pbm shareMenu-Engaged
> bottomNav-HomePage
> 
> Screenshot shows homepage button in URL bar in private browsing mode with
> menu open.

The share menu icons are the same as used on the bottom nav. They are in the send and send.pressed imagesets
The label on that should read 'Send' and not 'Share'.

bottomNav icons are attached to bug 1260449

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8752860 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1817

Works well! Just have some polish questions around strings/assets.

Comment 5

[James Hugman [:jhugman] [@jhugman]]

:tecgirl

I've addressed :bnicholson's pbm issue with icons, though he has another one with taller/blurry send icon.

https://github.com/mozilla/firefox-ios/pull/1817#discussion_r63403893

Addressed all other feedback, ready for re-review.

Comment 6

[James Hugman [:jhugman] [@jhugman]]

Should be merged into https://github.com/mozilla/firefox-ios/pull/1772

Comment 7

[Brian Nicholson (:bnicholson)]

Comment on attachment 8752860 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1817

Question about setting the pref on each init, but otherwise LGTM assuming the share menu assets get fixed.

Comment 8

[Robin Andersen [:tecgirl]]

Comment on attachment 8752861 [details]
Simulator Screen Shot May 16, 2016, 3.36.03 PM.png

Looking good! 

Nits: The pagination dots will need to shift to grey for normal browsing mode.

String update:
Remove 'the' from "You can change this at any time in the Settings" 

Possible bug: After setting a homepage, it displays in Settings but the "Show homepage icon" in menu is set to 'off'.

Comment 9

[James Hugman [:jhugman] [@jhugman]]

tecgirl feedback: 

 * Filed pagination dots color bug 1273864.
 * Updated String
 * Not sure what you mean. The toggle should switch the position of the homepage button (menu or toolbar).

Comment 10

[Brian Nicholson (:bnicholson)]

Attachment: Share menu image

Do we have a bug on file to fix the share asset in the menu? The share button is a noticeably lighter shade of gray than the other menu buttons. It also appears taller since it's the only image in the menu that doesn't have padding -- see attachment.

Comment 11

[James Hugman [:jhugman] [@jhugman]]

Opened https://bugzilla.mozilla.org/show_bug.cgi?id=1273952 to track this there.

Comment 12

[Robin Andersen [:tecgirl]]

(In reply to James Hugman [:jhugman] [@jhugman] from comment #9)
> tecgirl feedback: 
> 
>  * Filed pagination dots color bug 1273864. ✓
>  * Updated String ✓

>  * Not sure what you mean. The toggle should switch the position of the
> homepage button (menu or toolbar).
 - it doesn't! see http://c.tecgirl.com/gDjJ (immediately after setting page)