1265668 - Enabling ES3 by default for WebGL

Status: RESOLVED WONTFIX

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ethan Lin[:ethlin]]

Some extensions may need functions from ES3, like EXT_disjoint_timer_query. For now we use ES2 for WebGL1, so we cannot support these kind of extensions. We should try to use ES3 for WebGL1 if it can fall back to ES2.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Enabling ES3 by default.

Enabling ES3 by default. I will sent to try server and also try the conformance test 1.0.3 to see the impact of this.

Comment 2

[Ethan Lin[:ethlin]]

try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=95ef1a62fdd3

Comment 3

[Kelsey Gilbert [:jgilbert]]

I think we should do this.

Please add a pref:
webgl.enable-es3-webgl1: true

Any comments, jrmuizel?

Comment 4

[Ethan Lin[:ethlin]]

There are some failures on try server after set ES3 as default on win8. I will study these tests first.

1. Assertion failure: false (We should have caught all other errors.), at c:/builds/moz2_slave/try-w64-0000000000000000000000/build/src/dom/canvas/WebGLTextureUpload.cpp:1832
TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__misc__uninitialized-test.html | application terminated with exit code 1
PROCESS-CRASH | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__misc__uninitialized-test.html | application crashed [@ mozilla::WebGLTexture::CopyTexImage2D(StrongGLenum<TexImageTargetDetails>,int,unsigned int,int,int,int,int,int)]

2. 501 INFO TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-mochitest/test_depth_tex_lazy_clear.html | Should have no errors.

3. 542 INFO TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-mochitest/test_implicit_color_buffer_float.html | OES_texture_half_float should allow float textures.
Return code: 1

Comment 5

[Ethan Lin[:ethlin]]

Attachment: Part1. Enabling ES3 by default.

Add fall back flow of es3 to es2.

Comment 6

[Ethan Lin[:ethlin]]

Attachment: Part2. Add preference webgl.enable-es3-webgl1.

Add preference webgl.enable-es3-webgl1.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Does Chrome do this?

Comment 8

[Ethan Lin[:ethlin]]

I made a chromium build and I think chrome still use ES2 in webgl1. I will check how does chrome support EXT_disjoint_timer_query in webgl1.

Comment 9

[Ethan Lin[:ethlin]]

Per discussion with jgilbert, chrome just returns 0 when the platform doesn't support GetInteger64v. So we don't need to enable ES3 by default.