Closed Bug 1265668 Opened 9 years ago Closed 8 years ago

Enabling ES3 by default for WebGL

Categories

(Core :: Graphics: CanvasWebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: ethlin, Assigned: ethlin)

References

Details

Attachments

(2 files, 1 obsolete file)

Some extensions may need functions from ES3, like EXT_disjoint_timer_query. For now we use ES2 for WebGL1, so we cannot support these kind of extensions. We should try to use ES3 for WebGL1 if it can fall back to ES2.
Attached patch Enabling ES3 by default. (obsolete) — Splinter Review
Enabling ES3 by default. I will sent to try server and also try the conformance test 1.0.3 to see the impact of this.
Summary: Set PREFER_ES3 for WebGL1 → Enabling ES3 by default for WebGL
I think we should do this. Please add a pref: webgl.enable-es3-webgl1: true Any comments, jrmuizel?
Flags: needinfo?(jmuizelaar)
There are some failures on try server after set ES3 as default on win8. I will study these tests first. 1. Assertion failure: false (We should have caught all other errors.), at c:/builds/moz2_slave/try-w64-0000000000000000000000/build/src/dom/canvas/WebGLTextureUpload.cpp:1832 TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__misc__uninitialized-test.html | application terminated with exit code 1 PROCESS-CRASH | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__misc__uninitialized-test.html | application crashed [@ mozilla::WebGLTexture::CopyTexImage2D(StrongGLenum<TexImageTargetDetails>,int,unsigned int,int,int,int,int,int)] 2. 501 INFO TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-mochitest/test_depth_tex_lazy_clear.html | Should have no errors. 3. 542 INFO TEST-UNEXPECTED-FAIL | dom/canvas/test/webgl-mochitest/test_implicit_color_buffer_float.html | OES_texture_half_float should allow float textures. Return code: 1
Depends on: 1267147
Depends on: 1267149
Add fall back flow of es3 to es2.
Attachment #8742729 - Attachment is obsolete: true
Add preference webgl.enable-es3-webgl1.
Does Chrome do this?
Flags: needinfo?(jmuizelaar)
I made a chromium build and I think chrome still use ES2 in webgl1. I will check how does chrome support EXT_disjoint_timer_query in webgl1.
Per discussion with jgilbert, chrome just returns 0 when the platform doesn't support GetInteger64v. So we don't need to enable ES3 by default.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
See Also: → 1284323
See Also: → 1906155
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: