1267149 - WebGL2 conformance test fail: conformance2/textures/misc/tex-input-validation.html

Status: RESOLVED DUPLICATE of bug 1305864

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ethan Lin[:ethlin]]

We will have the assertion[1] in CopySubTexImage on windows.
[1] https://dxr.mozilla.org/mozilla-central/source/dom/canvas/WebGLTextureUpload.cpp#1942

Comment 1

[Vincent Liu[:vliu]]

From tracking with Visual Studio, the code returns before doing |context->copyTexSubImage2D|.

https://dxr.mozilla.org/mozilla-central/source/gfx/angle/src/libGLESv2/entry_points_gles_2_0.cpp?case=true&from=entry_points_gles_2_0.cpp#786

I will do further tracking to narrow down issue.

Comment 2

[Vincent Liu[:vliu]]

I tried to simplified the test case and found this test case also crashed in below when running [1].

[1]:https://dxr.mozilla.org/mozilla-central/source/dom/canvas/WebGLTextureUpload.cpp#1700 

Since destinationFormat was set to RGB565 which didn't defined in [2], it fall back to default.  

[2]:https://dxr.mozilla.org/mozilla-central/source/gfx/angle/src/libANGLE/renderer/d3d/d3d11/Blit11.cpp#512

I would tried to study the spec to find out root cause.

Comment 3

[Vincent Liu[:vliu]]

Attachment: WIP-fix-assertion-for-mismatched-format.patch

Hi Jeff,
The attached WIP intends to fix the crash happens in [1] when I tried to simplify the test and only keep CopyTexSubImage2D part.

[1]https://dxr.mozilla.org/mozilla-central/source/gfx/angle/src/libANGLE/renderer/d3d/d3d11/Blit11.cpp#512

The idea of WIP to fix it came from observing the code from Chrome. I'd also tried the same test in Chrome Canary, it turns out that Chrome Canary pass all test in CopyTexSubImage2D part.

In Chrome, it seems the dest_internal_format in [2] got from its caller, which was from internalFormat. ANGLE can recognizes the internalFormat and mapped to correct BlitShaderType.

[2]: https://code.google.com/p/chromium/codesearch#chromium/src/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc&sq=package:chromium&l=434&rcl=1464203926

I would like to got the feedback from you if you are also think it is fine for the the WIP.

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8756733 [details] [diff] [review]
WIP-fix-assertion-for-mismatched-format.patch

Review of attachment 8756733 [details] [diff] [review]:
-----------------------------------------------------------------

This is complicated. I'm working on this in a different bug.

Comment 5

[Vincent Liu[:vliu]]

Based on Comment 4, I will untake this bug to prevent duplicate work.