1265774 - EditComments doesn't work in 5.0.2

Status: VERIFIED WONTFIX

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Albert Ting]

I have been using a 12-2014 snapshot of EditComments that worked fine in 5.0rc3 as well as 5.0.2.  But the latest snapshot of EditComments doesn't work in 5.0.2.

I have not dug deeper to figure out why.

Comment 1

[:glob ✱]

the editcomments extension was reworked in bug 1153101, and now only supports BMO's new show_bug UI (ie. it won't work on upstream bugzilla anymore).

the last revision that may work is https://github.com/mozilla/webtools-bmo-bugzilla/tree/5265c09db899e148ceef6ba47aa199fa1e282e7b/extensions/EditComments

Comment 2

[Albert Ting]

Thanks Byron, any plans to make EditComments aligned with Bugzilla?  Or perhaps after bug_modal have been migrated to Bugzilla?

Comment 3

[David Lawrence [:dkl]]

(In reply to Albert Ting from comment #2)
> Thanks Byron, any plans to make EditComments aligned with Bugzilla?  Or
> perhaps after bug_modal have been migrated to Bugzilla?

Not from the BMO team specifically. When/if bug modal is merged upstream, it should make it easier to make the extension part of the core by someone who wants to take on the task.

dkl

Comment 4

[Dylan Hardison [:dylan] (he/him)]

A working version of EditComments is now at https://github.com/bugzilla/EditComments and patches are welcome.

There is even a branch (modal) for the same version we have in bmo, which we may need since Modal is going to be ported for Bugzilla 6.

Comment 5

[Albert Ting]

Thanks.  Hopefully this will eventually be moved to bugzilla itself, as well as InlineHistory.  They both work quite well.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

EditComments is far more likely to be upstreamed in its current form. InlineHistory is a mess to integrate.

Comment 7

[Albert Ting]

I've been using InlineHistory for about a year as well.  No major issues other than some Markdown integration updates such as bug 1130760