Closed
Bug 1265799
Opened 9 years ago
Closed 9 years ago
Disable b2g-inbound
Categories
(Infrastructure & Operations Graveyard :: CIDuty, task)
Infrastructure & Operations Graveyard
CIDuty
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: vciobancai)
References
Details
Attachments
(6 files)
5.68 KB,
patch
|
kmoir
:
review+
vciobancai
:
checked-in+
|
Details | Diff | Splinter Review |
1.23 KB,
patch
|
kmoir
:
review+
vciobancai
:
checked-in+
|
Details | Diff | Splinter Review |
879 bytes,
patch
|
kmoir
:
review+
vciobancai
:
checked-in+
|
Details | Diff | Splinter Review |
573 bytes,
patch
|
kmoir
:
review+
vciobancai
:
checked-in+
|
Details | Diff | Splinter Review |
1.41 KB,
patch
|
kmoir
:
review+
vciobancai
:
checked-in+
|
Details | Diff | Splinter Review |
1014 bytes,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
b2g-inbound is no longer needed for development. Let's disable all buildbot automation running there.
Updated•9 years ago
|
Component: General Automation → Buildduty
QA Contact: catlee → bugspam.Callek
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → vlad.ciobancai
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8743322 -
Flags: review?(kmoir)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8743324 -
Flags: review?(kmoir)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8743325 -
Flags: review?(kmoir)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8743327 -
Flags: review?(kmoir)
Assignee | ||
Comment 5•9 years ago
|
||
I tested the changes on dev-master2 by running the test-master.sh and script run without issues
Updated•9 years ago
|
Attachment #8743322 -
Flags: review?(kmoir) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8743324 [details] [diff] [review]
bug1265799_mozharness.patch
this patch looks good, however, you might want to check in-tree (mozilla-inbound) mozharness configs for references to b2g-inbound like you did for the other bug
Attachment #8743324 -
Flags: review?(kmoir) → review+
Updated•9 years ago
|
Attachment #8743325 -
Flags: review?(kmoir) → review+
Updated•9 years ago
|
Attachment #8743327 -
Flags: review?(kmoir) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8743736 -
Flags: review?(kmoir)
Assignee | ||
Comment 8•9 years ago
|
||
Attachment #8743740 -
Flags: review?(jmaher)
Comment 9•9 years ago
|
||
Comment on attachment 8743740 [details] [diff] [review]
bug1265799_mozilla-inbound.patch
Review of attachment 8743740 [details] [diff] [review]:
-----------------------------------------------------------------
I am not familiar with this code, technically I don't see anything wrong with it, let me pass to review to callek
Attachment #8743740 -
Flags: review?(jmaher) → review?(bugspam.Callek)
Updated•9 years ago
|
Attachment #8743736 -
Flags: review?(kmoir) → review+
Comment 10•9 years ago
|
||
Comment on attachment 8743740 [details] [diff] [review]
bug1265799_mozilla-inbound.patch
I've never touched either file, so had to brush up a bit, but looks good to me.
Attachment #8743740 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 11•9 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #10)
> Comment on attachment 8743740 [details] [diff] [review]
> bug1265799_mozilla-inbound.patch
>
> I've never touched either file, so had to brush up a bit, but looks good to
> me.
I run the change on try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a72b94920a9d3b81423a488ebda28c6c5afde79
Assignee | ||
Comment 12•9 years ago
|
||
(In reply to Vlad Ciobancai [:vladC] from comment #11)
> (In reply to Justin Wood (:Callek) from comment #10)
> > Comment on attachment 8743740 [details] [diff] [review]
> > bug1265799_mozilla-inbound.patch
> >
> > I've never touched either file, so had to brush up a bit, but looks good to
> > me.
>
> I run the change on try
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=6a72b94920a9d3b81423a488ebda28c6c5afde79
The attachment 8743740 [details] [diff] [review] have been tested on try and from what I can see everything run OK, can you please validate that I'm correct or not ?
If the patch is OK can somebody help me to land it to m-i ?
Flags: needinfo?(jmaher)
Comment 13•9 years ago
|
||
Assignee | ||
Comment 14•9 years ago
|
||
kmoir I think the rest of patches can be landed , right ?
Flags: needinfo?(kmoir)
Assignee | ||
Updated•9 years ago
|
Attachment #8743322 -
Flags: checked-in+
Assignee | ||
Updated•9 years ago
|
Attachment #8743324 -
Flags: checked-in+
Assignee | ||
Updated•9 years ago
|
Attachment #8743325 -
Flags: checked-in+
Assignee | ||
Updated•9 years ago
|
Attachment #8743327 -
Flags: checked-in+
Assignee | ||
Updated•9 years ago
|
Attachment #8743736 -
Flags: checked-in+
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(jmaher)
Assignee | ||
Comment 16•9 years ago
|
||
jmaher thank you for your help also I land the rest of the patches.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 17•9 years ago
|
||
bugherder |
Comment 18•9 years ago
|
||
changes to mozharness were not passing tests
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 19•9 years ago
|
||
https://hg.mozilla.org/build/mozharness/rev/449a5bc0876875c7721218586cf9175a49a520a6
Bug 1265799 - Disable b2g-inbound broke mozharness; r=me
Comment 20•9 years ago
|
||
changes in comment 19 backed out the changes to beagle.py. As I noted in another bug, any changes to vcs-sync should occur in their own bug, as it is handled by a team-other-than-releng. As with the prior case, there is nothing to be done to vcs-sync until the repo is deleted.
Please make sure you can run the tests locally on mozharness repo, and watch for the messages in #releng after commit. Both methods will help ensure you don't leave failing tests committed.
If all the work for this bug is still functional, you can close it again.
Flags: needinfo?(vciobancai)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(vciobancai)
Assignee | ||
Comment 21•9 years ago
|
||
From what I can see yes, maybe kmoir can confirm
Flags: needinfo?(kmoir)
Comment 22•9 years ago
|
||
I don't understand what you are asking me to confirm. Hal mentioned that vcs-sync shouldn't be changed because it's near end of life, so I think we are good.
Flags: needinfo?(kmoir)
Assignee | ||
Comment 23•9 years ago
|
||
Thank you Kim, I will close the bug
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
See Also: → 1275337
Updated•7 years ago
|
Product: Release Engineering → Infrastructure & Operations
Updated•6 years ago
|
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•