Add support for RTCPeerConnectionState in RTCPeerConnection
Categories
(Core :: WebRTC, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: rajmohanbanavi, Assigned: bwc)
References
(Blocks 3 open bugs)
Details
(Keywords: dev-doc-complete)
Attachments
(2 files, 1 obsolete file)
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.75 Safari/537.36 Steps to reproduce: The current WebRTC spec mentions about RTCPeerConnectionState read only attribute in the peer connection object. Actual results: Did not locate this attribute in the pc object Expected results: Need to add support for the same.
Reporter | ||
Comment 1•7 years ago
|
||
https://www.w3.org/TR/webrtc/#rtcpeerconnectionstate-enum
Updated•7 years ago
|
Updated•7 years ago
|
Comment 2•7 years ago
|
||
The RTCPeerConnectionState enum has been documented: https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection#RTCPeerConnectionState_enum RTCPeerConnection.connectionState has also been documented: https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/connectionState The compatibility table on connectionState indicates the lack of implementation. Leaving this in doc-needed state, however, because additions will have to be made to Firefox X for developers once it's implemented.
There has been no update to this bug in a few months. Can this be prioritized please? Thanks!
Updated•6 years ago
|
Comment 5•6 years ago
|
||
Mass change P1->P2 to align with new Mozilla triage process
Comment 6•5 years ago
|
||
Moving to p3 because no activity for at least 1 year(s). See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Comment 7•5 years ago
|
||
Moving to p3 because no activity for at least 1 year(s). See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Comment 8•5 years ago
|
||
Chrome just landed connectionState in Chrome 72.
Updated•5 years ago
|
Comment 9•5 years ago
|
||
Since the PeerConnectionState appears to be an aggregate of ICE connection state and DTLS connection state I'm not sure if it makes sense to try to implement this without implementing the DTLS connection object as well.
Assignee | ||
Comment 10•4 years ago
|
||
This is already causing timeouts in at least some web-platform-tests from upstream.
Updated•4 years ago
|
Comment 11•2 years ago
|
||
Hello!
Coming back to this in 2021, I wonder if there is a particular reason why this API is sitting at P2 (for years!) and not getting implemented?
Related:
- WebRTC 1.0 is moved from Candidate Recommentation to Recommentation
- Standard
RTCPeerConnection
Interface Definition from the W3C Draft
I was also iterating through some links over MDN docs & GitHub side, someone suggested using RTCPeerConnection.iceConnectionState
as a workaround but according to the standard (and also MDN covers this very well), that wouldn't cover the exact same connection state information & behavior.
So, I wanted to bump this thread up to get more information.
Hopefully, this ticket would be triaged to higher priority so that an implementation might get into the next FF release cycle :)
Comment 12•2 years ago
|
||
Subscribes to dtls changes and aggragates them together with the iceConnectionState.
The aggregates state is exposed as RTCPeerConnection.connectionState.
The respective events are dispatched for connectionstatechange
Updated•2 years ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Comment 13•1 year ago
|
||
Sorry for taking so long with this. Will try to get to review tomorrow.
Comment 14•11 months ago
|
||
The bug assignee didn't login in Bugzilla in the last months and this bug has priority 'P2'.
:mjf, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 15•11 months ago
|
||
(In reply to Jan-Ivar Bruaroey [:jib] (needinfo? me) from comment #13)
Sorry for taking so long with this. Will try to get to review tomorrow.
:jib - have you had a chance to look at the patch?
Comment 16•11 months ago
|
||
Byron reviewed this on March 30th and unfortunately we haven't heard back from the contributor. Unfortunately, a lot of refactoring has happened in the code this patch touches since it was written. I'm thankful for the contributor providing this patch, and it's on us that we didn't review it in time.
At this point our best path forward may be for someone to commandeer the revision (keeping original attribution) and salvage necessary parts to where they need to go in the new structure. Byron would probably be able to do this quickest, since he did the refactor, with me coming in second.
Byron, does that sound right?
Assignee | ||
Comment 17•11 months ago
|
||
I think that's the best way forward at this point.
Updated•8 months ago
|
Comment 18•7 months ago
|
||
Any chances to see this land in a release?
Some apps would like to support Firefox for WebRTC
Assignee | ||
Comment 19•4 months ago
|
||
Ok, I think we ought to be able to just implement this in terms of RTCDtlsTransport.state, which we already have implemented. I think this ought to be relatively easy.
Updated•4 months ago
|
Assignee | ||
Comment 20•4 months ago
|
||
Also, update meta files for tests that still fail for another reason.
Assignee | ||
Comment 21•4 months ago
|
||
Depends on D168142
Assignee | ||
Comment 22•4 months ago
|
||
Assignee | ||
Comment 23•4 months ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1643050#c2 indicates that split.https.html might work once this is implemented, but I have not noticed that. Just adding a note here.
Assignee | ||
Comment 24•4 months ago
|
||
Looks like split.https.html works with this change now.
https://treeherder.mozilla.org/jobs?repo=try&revision=51ff7f521dde5e8f560bcfc6271ad7f1887204a5
Comment 26•4 months ago
|
||
The severity field for this bug is set to S3
. However, the following bug duplicate has higher severity:
- Bug 1635922: S2
:bwc, could you consider increasing the severity of this bug to S2
?
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•4 months ago
|
Assignee | ||
Comment 27•4 months ago
|
||
Comment 28•4 months ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0dba91984a39 Re-enable wpt for RTCPeerConnectionState. r=jib https://hg.mozilla.org/integration/autoland/rev/56f00875890b Implement RTCPeerConnectionState. r=jib,webidl,smaug
Comment 29•4 months ago
|
||
Backed out for causing build bustages on PeerConnectionImpl.cpp
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp:2024:38: error: unused variable 'id' [-Werror=unused-variable]
mochitest log: https://treeherder.mozilla.org/logviewer?job_id=405685822&repo=autoland
Comment 30•4 months ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/20130ff69694 Re-enable wpt for RTCPeerConnectionState. r=jib https://hg.mozilla.org/integration/autoland/rev/3bbf94f50b4e Implement RTCPeerConnectionState. r=jib,webidl,smaug
Comment 31•4 months ago
|
||
Backed out for causing wpt failures in
Backout link: https://hg.mozilla.org/integration/autoland/rev/19e0bc283894a3bf801c7edb6c73879c3aeec836
Comment 32•3 months ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d9a0fe10930 Re-enable wpt for RTCPeerConnectionState. r=jib https://hg.mozilla.org/integration/autoland/rev/b145b1e8ced6 Implement RTCPeerConnectionState. r=jib,webidl,smaug
Comment 33•3 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3d9a0fe10930
https://hg.mozilla.org/mozilla-central/rev/b145b1e8ced6
Updated•3 months ago
|
Comment 34•3 months ago
|
||
Is this something we should call out in the Fx113 relnotes? Please nominate if so.
Assignee | ||
Updated•2 months ago
|
Comment 35•26 days ago
|
||
FYI MDN docs for this, including the MDN release note can be tracked in https://github.com/mdn/content/issues/26146. Note this is still waiting on browser compatibility data to be reviewed.
Description
•