1265928 - Hide Adobe GMP on Windows XP in Firefox 46 and 47.

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We need to hide the Adobe GMP on Windows XP. i.e. we need to revert bug 1234099.

This is because we detected that we're getting lots of crashes with unencrpyted decoding using the Adobe GMP, and we only use it on Windows XP for unencrypted decoding, so we should not show it in the UI.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Hide Adobe GMP on Windows XP

We need to revert bug 1234099 so that we don't show the plugin in
the add-on manager on Windows XP, since now that unencrypted decoding
via Adobe GMP is disabled, we won't be using the Adobe GMP.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Hide Adobe GMP on Windows XP

We need to revert bug 1234099 so that we don't show the plugin in
the add-on manager on Windows XP, since now that unencrypted decoding
via Adobe GMP is disabled, we won't be using the Adobe GMP.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8743056 [details] [diff] [review]
Hide Adobe GMP on Windows XP

Review of attachment 8743056 [details] [diff] [review]:
-----------------------------------------------------------------

Carried r+ over from bug 1265815.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8743056 [details] [diff] [review]
Hide Adobe GMP on Windows XP

Approval Request Comment
[Feature/regressing bug #]: Download of Adobe Gecko Media Plugin/Content Decryption Module on Windows XP
[User impact if declined]: Adobe CDM will be downloaded and appear in the add-on manager, but won't be used by Firefox or do anything. Will confuse users.
[Describe test coverage new/current, TreeHerder]: We have tests for this
[Risks and why]: Fairly low; this is a revert to previous behaviour
[String/UUID change made/needed]: None

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8743056 [details] [diff] [review]
Hide Adobe GMP on Windows XP

[Triage Comment]

Hide the plugin since it is causing crashes. Please uplift to aurora, m-b an m-r.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-release/rev/bbaae244b47af3b0583106b7c03982fc2b9cbb5c
https://hg.mozilla.org/releases/mozilla-beta/rev/2bf75333123ea40b35900d8547f968729142c954
https://hg.mozilla.org/releases/mozilla-aurora/rev/0183e41ccb6406ddd558ba7fb63dbeff676788a5

Comment 7

[Chris Peterson [:cpeterson]]

Fixed in comment 6