Closed Bug 1266039 Opened 3 years ago Closed 3 years ago

Generate release promotion specific docker images as a part of release promotion process

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(2 files)

We can generate images in separate tasks and use them. This way we would optimize on AV refresh times too.
Duplicate of this bug: 1259425
Duplicate of this bug: 1259426
Comment on attachment 8743286 [details]
MozReview Request: Bug 1266039 - Generate release promotion specific docker images as a part of release promotion process r=Callek a=release DONTBUILD

https://reviewboard.mozilla.org/r/47677/#review44477

::: release/docker/beet-mover/Dockerfile:21
(Diff revision 1)
>      wget \
>      && apt-get clean
>  
>  COPY requirements.txt /tmp/
>  RUN pip install -r /tmp/requirements.txt
> -RUN freshclam --verbose
> +RUN for i in 1 2 3 4 5; do freshclam --verbose && break || sleep 15; done

could use a comment for why the for i in and break, etc. (and other spot)
Attachment #8743286 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8743286 [details]
MozReview Request: Bug 1266039 - Generate release promotion specific docker images as a part of release promotion process r=Callek a=release DONTBUILD

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47677/diff/1-2/
Comment on attachment 8743286 [details]
MozReview Request: Bug 1266039 - Generate release promotion specific docker images as a part of release promotion process r=Callek a=release DONTBUILD

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47677/diff/2-3/
Keywords: leave-open
Attached file PR for releasetasks
Attachment #8743641 - Flags: review?(jlund)
Comment on attachment 8743641 [details] [review]
PR for releasetasks

It didn't work in graph2, need to fix it first
Attachment #8743641 - Flags: review?(jlund)
Comment on attachment 8743641 [details] [review]
PR for releasetasks

ready now
Attachment #8743641 - Flags: review?(jlund)
Comment on attachment 8743641 [details] [review]
PR for releasetasks

r+ed in the PR
Attachment #8743641 - Flags: review?(jlund) → review+
Deployed. We'll see the results in beta1.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.