HomeScreenPrompt shown on top of tabs tray

RESOLVED FIXED in Firefox 49

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sebastian, Assigned: sebastian)

Tracking

unspecified
Firefox 49
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
If you load a URL and switch to the tabs tray fast then it's possible that we show the HomeScreenPrompt on top of the tabs tray.
(Assignee)

Updated

2 years ago
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Depends on: 1266477
(Assignee)

Comment 1

2 years ago
Created attachment 8743968 [details]
MozReview Request: Bug 1266383 - (Pre) BrowserAppDelegate - Add methods for tabs tray shown/hidden. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/48209/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48209/
Attachment #8743968 - Flags: review?(ahunt)
Attachment #8743969 - Flags: review?(ahunt)
(Assignee)

Comment 2

2 years ago
Created attachment 8743969 [details]
MozReview Request: Bug 1266383 - Do not show HomeScreenPrompt if tab is not in foreground. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/48211/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48211/

Updated

2 years ago
Attachment #8743968 - Flags: review?(ahunt) → review+

Comment 3

2 years ago
Comment on attachment 8743968 [details]
MozReview Request: Bug 1266383 - (Pre) BrowserAppDelegate - Add methods for tabs tray shown/hidden. r=ahunt

https://reviewboard.mozilla.org/r/48209/#review45355

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:2142
(Diff revision 1)
>              mTabsPanel.show(panel);
>  
>              // Hide potentially visible "find in page" bar (Bug 1177338)
>              mFindInPageBar.hide();
> +
> +            for (BrowserAppDelegate delegate : delegates) {

nit: we could make delegate final.

(Admittedly this loop is so simple we're unlikely to ever run into issues in future?)

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:2155
(Diff revision 1)
>          mTabsPanel.hide();
>          if (mDoorHangerPopup != null) {
>              mDoorHangerPopup.enable();
>          }
> +
> +        for (BrowserAppDelegate delegate : delegates) {

same here: we could make this final!

Comment 4

2 years ago
Comment on attachment 8743969 [details]
MozReview Request: Bug 1266383 - Do not show HomeScreenPrompt if tab is not in foreground. r=ahunt

https://reviewboard.mozilla.org/r/48211/#review45357
Attachment #8743969 - Flags: review?(ahunt) → review+
(Assignee)

Comment 5

2 years ago
https://reviewboard.mozilla.org/r/48209/#review45355

> nit: we could make delegate final.
> 
> (Admittedly this loop is so simple we're unlikely to ever run into issues in future?)

Good call. I'll actually add this for all loops of bug 1266477 too.
(Assignee)

Comment 6

2 years ago
Comment on attachment 8743968 [details]
MozReview Request: Bug 1266383 - (Pre) BrowserAppDelegate - Add methods for tabs tray shown/hidden. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48209/diff/1-2/
Attachment #8743968 - Attachment description: MozReview Request: Bug 1266383 - (Pre) BrowserAppDelegate - Add methods for tabs tray shown/hidden. r?ahunt → MozReview Request: Bug 1266383 - (Pre) BrowserAppDelegate - Add methods for tabs tray shown/hidden. r=ahunt
Attachment #8743969 - Attachment description: MozReview Request: Bug 1266383 - Do not show HomeScreenPrompt if tab is not in foreground. r?ahunt → MozReview Request: Bug 1266383 - Do not show HomeScreenPrompt if tab is not in foreground. r=ahunt
(Assignee)

Comment 7

2 years ago
Comment on attachment 8743969 [details]
MozReview Request: Bug 1266383 - Do not show HomeScreenPrompt if tab is not in foreground. r=ahunt

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48211/diff/1-2/
(Assignee)

Comment 8

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/be988dc7bd2063d7ad0c75e9244fe6aa1a998b84
Bug 1266383 - (Pre) BrowserAppDelegate - Add methods for tabs tray shown/hidden. r=ahunt

https://hg.mozilla.org/integration/fx-team/rev/b3c8e62a256c810a20cfee8dd127d00b7602af8c
Bug 1266383 - Do not show HomeScreenPrompt if tab is not in foreground. r=ahunt

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/be988dc7bd20
https://hg.mozilla.org/mozilla-central/rev/b3c8e62a256c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.