Closed Bug 1266417 Opened 5 years ago Closed 5 years ago

Add some left padding to the items in the device selector

Categories

(DevTools :: Responsive Design Mode, defect, P1)

defect

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Iteration:
49.2 - May 23
Tracking Status
firefox49 --- fixed

People

(Reporter: gl, Assigned: hholmes)

References

Details

(Whiteboard: [multiviewport] [mvp-rdm])

Attachments

(1 file, 1 obsolete file)

Extracted from https://bugzilla.mozilla.org/show_bug.cgi?id=1241720#c13:
> For the <select>: can we do somewhere between 3-5px left-padding on the items? They hug the left side really tightly, looks like they need breathing room.
Flags: qe-verify-
Priority: -- → P2
Assignee: nobody → hholmes
Status: NEW → ASSIGNED
Iteration: --- → 49.1 - May 9
Priority: P2 → P1
Blocks: 1172309
Attached patch left-padding.patch (obsolete) — Splinter Review
I also adjusted the padding on the select box itself with this patch since it was a quick change (just wanted it to appear more centered when expanded).
Attachment #8749660 - Flags: review?(gl)
Attachment #8749660 - Flags: review?(gl) → review?(zer0)
Iteration: 49.1 - May 9 → 49.2 - May 23
Comment on attachment 8749660 [details] [diff] [review]
left-padding.patch

Review of attachment 8749660 [details] [diff] [review]:
-----------------------------------------------------------------

My apologies for the delay, I got sick and I still didn't recover, but I wanted at least to avoid this patch to be blocked by me.

::: devtools/client/responsive.html/index.css
@@ +188,4 @@
>    background-color: var(--theme-toolbar-background);
>    color: var(--viewport-active-color);
>    text-align: left;
> +  padding: 5px 10px 5px 10px;

I think you can use the shorter form `5px 10px` here.
Attachment #8749660 - Flags: review?(zer0) → review+
Switched to the shorter syntax and rebased with fx-team.
Attachment #8749660 - Attachment is obsolete: true
Attachment #8751729 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/6fbaa6adef34
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.