Add some left padding to the items in the device selector

RESOLVED FIXED in Firefox 49

Status

()

Firefox
Developer Tools: Responsive Design Mode
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gl, Assigned: helenvholmes)

Tracking

unspecified
Firefox 49
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: [multiviewport] [mvp-rdm])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
Extracted from https://bugzilla.mozilla.org/show_bug.cgi?id=1241720#c13:
> For the <select>: can we do somewhere between 3-5px left-padding on the items? They hug the left side really tightly, looks like they need breathing room.

Updated

2 years ago
Flags: qe-verify-
Priority: -- → P2

Updated

2 years ago
Assignee: nobody → hholmes
Status: NEW → ASSIGNED
Iteration: --- → 49.1 - May 9
Priority: P2 → P1

Updated

2 years ago
Blocks: 1172309
Created attachment 8749660 [details] [diff] [review]
left-padding.patch

I also adjusted the padding on the select box itself with this patch since it was a quick change (just wanted it to appear more centered when expanded).
Attachment #8749660 - Flags: review?(gl)
(Assignee)

Updated

2 years ago
Attachment #8749660 - Flags: review?(gl) → review?(zer0)

Updated

2 years ago
Iteration: 49.1 - May 9 → 49.2 - May 23
Comment on attachment 8749660 [details] [diff] [review]
left-padding.patch

Review of attachment 8749660 [details] [diff] [review]:
-----------------------------------------------------------------

My apologies for the delay, I got sick and I still didn't recover, but I wanted at least to avoid this patch to be blocked by me.

::: devtools/client/responsive.html/index.css
@@ +188,4 @@
>    background-color: var(--theme-toolbar-background);
>    color: var(--viewport-active-color);
>    text-align: left;
> +  padding: 5px 10px 5px 10px;

I think you can use the shorter form `5px 10px` here.
Attachment #8749660 - Flags: review?(zer0) → review+
Created attachment 8751729 [details] [diff] [review]
left-padding.patch

Switched to the shorter syntax and rebased with fx-team.
Attachment #8749660 - Attachment is obsolete: true
Attachment #8751729 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/6fbaa6adef34
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6fbaa6adef34
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.