Closed
Bug 1172309
Opened 9 years ago
Closed 7 years ago
[userstory] Preset Device Choices
Categories
(DevTools :: Responsive Design Mode, defect)
DevTools
Responsive Design Mode
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jryans, Unassigned)
References
(Depends on 9 open bugs, )
Details
(Whiteboard: [multiviewport] [userstory])
User Story
User Story: * As a web developer I am targeting a specific device like the iPhone 5s and I would like to be able to easily choose that device by name from a list such that I don't have to look up the screen size and enter the information manually. Acceptance Criteria: * Common devices available from a regularly maintained list * Choosing a device change the viewport to match the constraints of the new device * List of popular devices for initial display to users as target devices * Way to customize the list of target devices Notes: *The entire device does not need to be available all at once, we may want an interface that allows you to choose a set of devices for a set of devices you intend to target. We have the beginnings of a device database on github which is being used for the WebIDE: https://github.com/jankeromnes/devices Competition: * Chrome offers a limited set of devices they build directly into Chrome releases. Their device list is more mature than ours and offers slightly more information. A side goal of ours is to work with Developer Services on a device list service that can crowd-source the information needed.
Attachments
(1 file)
|
10.02 KB,
patch
|
Details | Diff | Splinter Review |
Could have sworn there was a bug for this already... Anyway, we should integrate the device catalog into the responsive mode preset list.
|
||
Updated•9 years ago
|
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
|
Reporter | |
Comment 1•9 years ago
|
||
I have local patch that implements this, but it's also based on top of a large patch set... Anyway, you are welcome to give it a shot if you like! I'll likely come back and land my version eventually if it's not done by then.
|
|
||
Comment 2•9 years ago
|
||
This patch adds the functionality, but the command button no longer updates it's state. I guess the way we check for responsive mode state will probably need a refactor unless we don't use async initialization.
|
|
||
Updated•9 years ago
|
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW
|
|
Reporter | |
Updated•9 years ago
|
Blocks: multiple-viewports-v1
|
|
Reporter | |
Updated•9 years ago
|
Whiteboard: [devtools-ux]
|
||
Updated•9 years ago
|
User Story: (updated)
Flags: qe-verify-
Summary: Use device catalog in Responsive Mode → [userstory] Preset Device Choices
Whiteboard: [devtools-ux] → [multiviewport] [userstory]
|
|
Reporter | |
Comment 3•9 years ago
|
||
Device DB: https://github.com/jankeromnes/devices
|
|
||
Updated•9 years ago
|
User Story: (updated)
|
|
||
Updated•9 years ago
|
User Story: (updated)
|
|
Reporter | |
Updated•8 years ago
|
No longer blocks: multiple-viewports-v1
|
|
Reporter | |
Comment 5•7 years ago
|
||
I believe this feature is complete according to the user story in 52 and later. We can track bugs and tweaks separately.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•