[userstory] Preset Device Choices

RESOLVED FIXED

Status

()

Firefox
Developer Tools: Responsive Design Mode
RESOLVED FIXED
3 years ago
4 months ago

People

(Reporter: jryans, Unassigned)

Tracking

(Depends on: 12 bugs, Blocks: 1 bug)

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [multiviewport] [userstory], URL)

User Story

User Story:

* As a web developer I am targeting a specific device like the iPhone 5s and I would like to be able to easily choose that device by name from a list such that I don't have to look up the screen size and enter the information manually.

Acceptance Criteria:

* Common devices available from a regularly maintained list
* Choosing a device change the viewport to match the constraints of the new device
* List of popular devices for initial display to users as target devices
* Way to customize the list of target devices

Notes:

*The entire device does not need to be available all at once, we may want an interface that allows you to choose a set of devices for a set of devices you intend to target.

We have the beginnings of a device database on github which is being used for the WebIDE:  https://github.com/jankeromnes/devices

Competition:

* Chrome offers a limited set of devices they build directly into Chrome releases.  Their device list is more mature than ours and offers slightly more information.  A side goal of ours is to work with Developer Services on a device list service that can crowd-source the information needed.

Attachments

(1 attachment)

Could have sworn there was a bug for this already...

Anyway, we should integrate the device catalog into the responsive mode preset list.

Updated

3 years ago
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
I have local patch that implements this, but it's also based on top of a large patch set...

Anyway, you are welcome to give it a shot if you like!  I'll likely come back and land my version eventually if it's not done by then.

Comment 2

3 years ago
Created attachment 8626307 [details] [diff] [review]
WIP patch

This patch adds the functionality, but the command button no longer updates it's state. I guess the way we check for responsive mode state will probably need a refactor unless we don't use async initialization.

Updated

3 years ago
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW
Blocks: 1179734
Blocks: 1184438
Whiteboard: [devtools-ux]

Updated

2 years ago
User Story: (updated)
Flags: qe-verify-
Summary: Use device catalog in Responsive Mode → [userstory] Preset Device Choices
Whiteboard: [devtools-ux] → [multiviewport] [userstory]

Updated

2 years ago
Depends on: 1237873
Device DB: https://github.com/jankeromnes/devices

Updated

2 years ago
User Story: (updated)

Updated

2 years ago
User Story: (updated)
Depends on: 1241713
Depends on: 1241714
Depends on: 1241720
Depends on: 1247290
Depends on: 1247302
Depends on: 1249295
Depends on: 1254385
Depends on: 1254386
Depends on: 1254388
Depends on: 1254390
Depends on: 1254392
Depends on: 1262829

Updated

2 years ago
Depends on: 1266414

Updated

2 years ago
Depends on: 1266417
Depends on: 1269441
Depends on: 1269739
Depends on: 1269750
Depends on: 1273584
Depends on: 1266411
Depends on: 1278909

Updated

2 years ago
Depends on: 1259132
Depends on: 1284463
Depends on: 1291263
Depends on: 1297431
Depends on: 1299450
Depends on: 1302964
Depends on: 1303699
Depends on: 1309292
Duplicate of this bug: 1029467
No longer blocks: 1184438
Depends on: 1325571
Depends on: 1325124
Depends on: 1325563
I believe this feature is complete according to the user story in 52 and later.  We can track bugs and tweaks separately.
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.