Session restore's remoteness switches inadvertently is still switching to about:blank inbetween loads

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
Firefox 48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
As per summary. This causes flickering of the URL in the URL bar when you e.g.:

1. load yahoo.com
2. load about:preferences
3. hit the back button

because we end up clearing the URL bar for about:blank in the middle somewhere.

The comments in ContentRestore.jsm suggest this is not on purpose, and while the flickering is fairly subtle in the current implementation because of quirks in how userTypedClear and userTypedValue behave, it is worse when you try to make those things more sane, as I'm trying to do in bug 1241085. :-)

The good news is that this problem is independently fixable, and I have an automated test for it. Patch incoming.
Assignee

Comment 2

3 years ago
(I could be convinced to stick the test in a sessionstore directory instead... I guess it doesn't directly verify anything about the location bar. :-\ )
Attachment #8743953 - Flags: review?(mconley) → review+
Comment on attachment 8743953 [details]
MozReview Request: Bug 1266475 - don't re-load about:blank when we're remoteness-switching anyway, r?mconley

https://reviewboard.mozilla.org/r/48197/#review44891

Thanks!

::: browser/base/content/test/urlbar/browser_urlbar_remoteness_switch.js:2
(Diff revision 1)
> +"use strict";
> +

Mind adding a quick docstring describing what this test is doing / testing?
Comment hidden (off-topic)

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6d26d2099e1a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.