Move MACOSX_DEPLOYMENT_TARGET to moz.configure

RESOLVED FIXED in Firefox 48

Status

defect
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: glandium, Unassigned)

Tracking

(Blocks 1 bug)

unspecified
mozilla48
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

I think bug 1259382 is what is causing the pain with 10.6 tests on try because sccache only checks MACOSX_DEPLOYMENT_TARGET in its server (which is wrong), and we now end up launching the sccache server before MACOSX_DEPLOYMENT_TARGET is set appropriately.

So moving it to moz.configure should make us start the sccache server with MACOS_DEPLOYMENT_TARGET set properly again.
(In reply to Mike Hommey [:glandium] from comment #0)
> I think bug 1259382 is what is causing the pain with 10.6 tests on try.

And confirmed it is.
Comment on attachment 8744145 [details]
MozReview Request: Bug 1266620 - Move MACOSX_DEPLOYMENT_TARGET to moz.configure. r?chmanchester

https://reviewboard.mozilla.org/r/48309/#review45261
Attachment #8744145 - Flags: review?(cmanchester) → review+
https://hg.mozilla.org/mozilla-central/rev/fb0d7b82c072
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.