1266620 - Move MACOSX_DEPLOYMENT_TARGET to moz.configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

I think bug 1259382 is what is causing the pain with 10.6 tests on try because sccache only checks MACOSX_DEPLOYMENT_TARGET in its server (which is wrong), and we now end up launching the sccache server before MACOSX_DEPLOYMENT_TARGET is set appropriately.

So moving it to moz.configure should make us start the sccache server with MACOS_DEPLOYMENT_TARGET set properly again.

Comment 1

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #0)
> I think bug 1259382 is what is causing the pain with 10.6 tests on try.

And confirmed it is.

Comment 2

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1266620 - Move MACOSX_DEPLOYMENT_TARGET to moz.configure. r?chmanchester

Review commit: https://reviewboard.mozilla.org/r/48309/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48309/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8744145 [details]
MozReview Request: Bug 1266620 - Move MACOSX_DEPLOYMENT_TARGET to moz.configure. r?chmanchester

https://reviewboard.mozilla.org/r/48309/#review45261

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb0d7b82c072

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fb0d7b82c072