Remove PushPermissionDescriptor from the Permissions API

RESOLVED FIXED in Firefox 48

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: lina, Assigned: lina)

Tracking

({dev-doc-complete, site-compat})

unspecified
mozilla49
dev-doc-complete, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48+ fixed, firefox49+ fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

Created attachment 8744430 [details] [diff] [review]
noPushDescriptor.patch

We currently throw "NS_ERROR_NOT_IMPLEMENTED" for PushPermissionDescriptors with `userVisibleOnly: true`. This is incompatible with Chrome, which requires that option.

Since we use a quota instead of userVisibleOnly, I think we should just remove PushPermissionDescriptor entirely, and treat it like any other permission request.
Attachment #8744430 - Flags: review?(amarchesini)
Status: NEW → ASSIGNED
Whiteboard: btpp-active
Attachment #8744430 - Flags: review?(amarchesini) → review+

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d600bbea44ca
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Updated

2 years ago
Target Milestone: mozilla48 → mozilla49
Comment on attachment 8744430 [details] [diff] [review]
noPushDescriptor.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1261405.
[User impact if declined]: Potential web compat issue. Chrome's implementation of the Permissions API requires an extra field when requesting the push permission, but Firefox throws if that field is specified.
[Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d681274533f1, https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d600bbea44ca
[Risks and why]: Low risk. The bulk of this patch deletes existing code, and the Permissions API is still experimental.
[String/UUID change made/needed]: None.
Attachment #8744430 - Flags: approval-mozilla-aurora?
Keywords: site-compat
Comment on attachment 8744430 [details] [diff] [review]
noPushDescriptor.patch

Fix web compatibility for push notification API.
Attachment #8744430 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Tracking to make sure this lands for 48.
status-firefox48: --- → affected
tracking-firefox48: --- → +
tracking-firefox49: --- → +

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/f5c86d60a789
status-firefox48: affected → fixed
I've updated the documentation on MDN to cover this:

The revoke and query pages:

https://developer.mozilla.org/en-US/docs/Web/API/Permissions/revoke
https://developer.mozilla.org/en-US/docs/Web/API/Permissions/query

The Fx 49 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/49#Service_Workers_and_related

Let me know if they're ok. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.