1266821 - Remove PushPermissionDescriptor from the Permissions API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Lina Butler [:lina]]

Attachment: noPushDescriptor.patch

We currently throw "NS_ERROR_NOT_IMPLEMENTED" for PushPermissionDescriptors with `userVisibleOnly: true`. This is incompatible with Chrome, which requires that option.

Since we use a quota instead of userVisibleOnly, I think we should just remove PushPermissionDescriptor entirely, and treat it like any other permission request.

Comment 1

[Lina Butler [:lina]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d681274533f1

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d600bbea44ca

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d600bbea44ca

Comment 4

[Lina Butler [:lina]]

Comment on attachment 8744430 [details] [diff] [review]
noPushDescriptor.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1261405.
[User impact if declined]: Potential web compat issue. Chrome's implementation of the Permissions API requires an extra field when requesting the push permission, but Firefox throws if that field is specified.
[Describe test coverage new/current, TreeHerder]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d681274533f1, https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d600bbea44ca
[Risks and why]: Low risk. The bulk of this patch deletes existing code, and the Permissions API is still experimental.
[String/UUID change made/needed]: None.

Comment 5

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8744430 [details] [diff] [review]
noPushDescriptor.patch

Fix web compatibility for push notification API.

Comment 6

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Tracking to make sure this lands for 48.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f5c86d60a789

Comment 8

[Kohei Yoshino]

Updated the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/permissions-query-s-uservisible-option-has-been-renamed-to-uservisibleonly/

Comment 9

[Chris Mills [:cmills]]

I've updated the documentation on MDN to cover this:

The revoke and query pages:

https://developer.mozilla.org/en-US/docs/Web/API/Permissions/revoke
https://developer.mozilla.org/en-US/docs/Web/API/Permissions/query

The Fx 49 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/49#Service_Workers_and_related

Let me know if they're ok. Thanks!