1266823 - TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_gdata_provider.js | xpcshell return code: 0

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect)

Description

[aleth [:aleth]]

Probably fallout from bug 1258835.

Comment 1

[aleth [:aleth]]

Typical errors:

 0:13.46 PROCESS_OUTPUT: Thread-2 (pid:15491) "Error: [calGoogleCalendar] Modifying item changed failed:2147500036: "
 0:13.46 LOG: Thread-2 ERROR Unexpected exception 2147500036
undefined
 0:13.46 LOG: Thread-2 INFO exiting test
 0:13.46 LOG: Thread-2 INFO "CONSOLE_MESSAGE: (error) [JavaScript Error: "[calGoogleCalendar] Modifying item changed failed:2147500036: " {file: "file:///builds/slave/test/build/application/Daily.app/Contents/Resources/extensions/%7Ba62ef8ec-5fdc-40c2-873c-223b8a6925cc%7D/components/calGoogleCalendar.js" line: 528}]"

PROCESS | 6341 | Error: [calGoogleCalendar] Adding Item Default Alarms failed:2147500036:
 12:42:39     INFO -  Unexpected exception 2147500036
 12:42:39     INFO -  undefined
 12:42:39     INFO -  exiting test
 12:42:39     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "[calGoogleCalendar] Adding Item Default Alarms failed:2147500036: " {file: "file:///builds/slave/test/build/application/Daily.app/Contents/Resources/extensions/%7Ba62ef8ec-5fdc-40c2-873c-223b8a6925cc%7D/components/calGoogleCalendar.js" line: 430}]"
12:42:39 INFO - <<<<<<<

 11:17:56     INFO -  PROCESS | 11992 | Error: [calGoogleCalendar] Adding Item New Event failed:2147500036:
 11:17:56     INFO -  Unexpected exception 2147500036
 11:17:56     INFO -  undefined
 11:17:56     INFO -  exiting test
 11:17:56     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "[calGoogleCalendar] Adding Item New Event failed:2147500036: " {file: "file:///C:/slave/test/build/application/thunderbird/extensions/%7Ba62ef8ec-5fdc-40c2-873c-223b8a6925cc%7D/components/calGoogleCalendar.js" line: 430}]"

Looks like something intermittently going wrong in the backend.

Comment 2

[Jorg K (CEST = GMT+2)]

Perhaps MakeMyDay can make our day here? Those xpcshell test failures have been around long enough to be annoying ;-)

Comment 3

[[:MakeMyDay]]

Sorry, but I'm not familiar with that gdata test and its mockup server. Based on the error number an NS_ERROR_ABORT occurred [1], which probably points to an authentication problem [2] while executing the test. Does this test also fail locally?

Philipp, do you have any ideas what's going on here?

[1] http://james-ross.co.uk/mozilla/misc/nserror?0x80004004
[2] https://mxr.mozilla.org/comm-central/search?find=%2Fcalendar%2F&string=NS_ERROR_ABORT

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

I think this is the issue I've mentioned in a bug somewhere, where the mock http server just breaks after a few requests. NS_ERROR_ABORT may hint towards not enough do_test_pending/do_test_finished though. I have no idea how to solve this, in the worst case we might just have to disable this test, which would be very discouraging because I spent a lot of time writing it :-/

Comment 5

[aleth [:aleth]]

(In reply to MakeMyDay from comment #3)
> Sorry, but I'm not familiar with that gdata test and its mockup server.
> Based on the error number an NS_ERROR_ABORT occurred [1], which probably
> points to an authentication problem [2] while executing the test. Does this
> test also fail locally?

Yes.

Comment 6

[aleth [:aleth]]

(In reply to Philipp Kewisch [:Fallen] from comment #4)
> I think this is the issue I've mentioned in a bug somewhere, where the mock
> http server just breaks after a few requests.

If I remember correctly, that one was hard to diagnose because it never happened locally. Fwiw, that's not the case here.

Comment 7

[[:MakeMyDay]]

Attachment: FixGdataTest-V1.diff

Instead of disabling the whole test we can just revert the changes from bug 1258835 for this test for now and file a followup bug to investigate why do_calendar_startup fails if applied in this test.

With the partly backout the test passes again, see https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=56dc9678a742dc601b083134ef2ea6789b93030b&selectedJob=18248

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8749630 [details] [diff] [review]
FixGdataTest-V1.diff

Review of attachment 8749630 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, lets do it!

Comment 9

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/5eca4100e0c9

Comment 10

[Jorg K (CEST = GMT+2)]

Aurora (Calendar 5.0):
https://hg.mozilla.org/releases/comm-aurora/rev/e0db7f7c33c8

Did I get the numbers right? There are no tracking flags for calendar, right?

Comment 11

[[:MakeMyDay]]

Right, no tracking flags, just updating og target milestone accordingly. Thanks for checking in.

Comment 12

[Jorg K (CEST = GMT+2)]

(In reply to MakeMyDay from comment #11)
> Right, no tracking flags, just updating of target milestone accordingly.
So you move the target milestone to the oldest one that got fixed. I'll remember that.

> Thanks for checking in.
I wanted to see the Aurora tree green(er) again ;-)