Closed Bug 1266844 Opened 4 years ago Closed 4 years ago

investigate devtools/shared/inspector/css-logic.js

Categories

(DevTools :: Framework, enhancement, P1)

enhancement

Tracking

(firefox50 fixed)

RESOLVED FIXED
Firefox 50
Iteration:
50.2 - Jul 4
Tracking Status
firefox50 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file)

devtools/shared/inspector/css-logic.js uses a number of chrome APIs.
However, it's unclear which parts of this run on the client.
So, we need to investigate that before taking action.
Flags: qe-verify-
Priority: -- → P2
Priority: P2 → P1
Some of it is dead code as well:
https://bugzilla.mozilla.org/show_bug.cgi?id=1225254
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Iteration: --- → 50.2
I think the route forward here is in three parts:
1. Delete dead code; bug 1225254
2. Split css-logic so that the server-only bits are in devtools/server
3. De-chrome the remaining code

I plan to do #2 and #3 here.
Depends on: 1225254
Also I should note that I plan to skip the l10n bits as those are being handled
in another bug.
Also leaving the nsIXULRuntime bit for the same reason.
Comment on attachment 8765026 [details]
Bug 1266844 - use URL, not nsIURL, in css-logic.js;

https://reviewboard.mozilla.org/r/60574/#review57858

So, `URL` is available as a global in our modules? That's nice.
Maybe we should think of creating some doc on the wiki about the environment available in modules, depending on how they were loaded, and sending an email to the mailing list about it.
Attachment #8765026 - Flags: review?(pbrosset) → review+
(In reply to Patrick Brosset <:pbro> from comment #6)
> Comment on attachment 8765026 [details]
> Bug 1266844 - use URL, not nsIURL, in css-logic.js;
> 
> https://reviewboard.mozilla.org/r/60574/#review57858
> 
> So, `URL` is available as a global in our modules? That's nice.

Yeah, since bug 1265813

> Maybe we should think of creating some doc on the wiki about the environment
> available in modules, depending on how they were loaded, and sending an
> email to the mailing list about it.

Good idea.
(In reply to Patrick Brosset <:pbro> from comment #6)

> Maybe we should think of creating some doc on the wiki about the environment
> available in modules, depending on how they were loaded, and sending an
> email to the mailing list about it.

Now bug 1283523
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/c6ce12a74300
use URL, not nsIURL, in css-logic.js; r=pbro
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c6ce12a74300
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.