1266844 - investigate devtools/shared/inspector/css-logic.js

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

devtools/shared/inspector/css-logic.js uses a number of chrome APIs.
However, it's unclear which parts of this run on the client.
So, we need to investigate that before taking action.

Comment 1

[Tom Tromey :tromey]

Some of it is dead code as well:
https://bugzilla.mozilla.org/show_bug.cgi?id=1225254

Comment 2

[Tom Tromey :tromey]

I think the route forward here is in three parts:
1. Delete dead code; bug 1225254
2. Split css-logic so that the server-only bits are in devtools/server
3. De-chrome the remaining code

I plan to do #2 and #3 here.

Comment 3

[Tom Tromey :tromey]

Also I should note that I plan to skip the l10n bits as those are being handled
in another bug.

Comment 4

[Tom Tromey :tromey]

Also leaving the nsIXULRuntime bit for the same reason.

Comment 5

[Tom Tromey :tromey]

Attachment: Bug 1266844 - use URL, not nsIURL, in css-logic.js;

Review commit: https://reviewboard.mozilla.org/r/60574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60574/

Comment 6

[Patrick Brosset <:pbro>]

Comment on attachment 8765026 [details]
Bug 1266844 - use URL, not nsIURL, in css-logic.js;

https://reviewboard.mozilla.org/r/60574/#review57858

So, `URL` is available as a global in our modules? That's nice.
Maybe we should think of creating some doc on the wiki about the environment available in modules, depending on how they were loaded, and sending an email to the mailing list about it.

Comment 7

[Tom Tromey :tromey]

(In reply to Patrick Brosset <:pbro> from comment #6)
> Comment on attachment 8765026 [details]
> Bug 1266844 - use URL, not nsIURL, in css-logic.js;
> 
> https://reviewboard.mozilla.org/r/60574/#review57858
> 
> So, `URL` is available as a global in our modules? That's nice.

Yeah, since bug 1265813

> Maybe we should think of creating some doc on the wiki about the environment
> available in modules, depending on how they were loaded, and sending an
> email to the mailing list about it.

Good idea.

Comment 8

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c13395a6eee

Comment 9

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc75ce6c3fc3f3820b36726ea62d140c91898327

Comment 10

[Tom Tromey :tromey]

(In reply to Patrick Brosset <:pbro> from comment #6)

> Maybe we should think of creating some doc on the wiki about the environment
> available in modules, depending on how they were loaded, and sending an
> email to the mailing list about it.

Now bug 1283523

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/c6ce12a74300
use URL, not nsIURL, in css-logic.js; r=pbro

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6ce12a74300