Closed Bug 1267071 Opened 4 years ago Closed 3 months ago

cs_nav_prefs_advanced.xhtml: Dead link behind "End User Guide to Proxy AutoConfiguration"

Categories

(SeaMonkey :: Help Documentation, defect)

SeaMonkey 2.45 Branch
Unspecified
All
defect
Not set
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.75
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: RainerBielefeldNG, Assigned: nunojsg)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.3)

Attachments

(2 files)

Steps how to reproduce with  English SeaMonkey 2.45a1  (Windows NT 6.1; WOW64; rv:48.0)  Gecko/20100101 Firefox/48.0 Build 20160308001946  (Default Classic Theme)  on German WIN7 64bit:

1. Browser → F1
   » Help appears
2. Type search strint "proxy" → Click hit "proxiy preferences"
   » Related Help appears
3. Click Link at text "End User Guide to Proxy AutoConfiguration"
   » opens <https://www.mozilla.org/en-US/catalog/end-user/customizing/enduserPAC.html> 
   Bug: "Whoops!" (Page does not exist)

a) I do not know where a help text can be found
b) This one might be related to "Bug 213699 - Write PAC docs "
It's still in the archive for reference, but that's probably not what we want to link to:
http://www-archive.mozilla.org/catalog/end-user/customizing/enduserPAC.html

A rather technical description is here, which is good for writing PAC files but not as starting point:
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Necko/Proxy_Auto-Configuration_%28PAC%29_file
(In reply to rsx11m from comment #1)
> A rather technical description is here, which is good for writing PAC files

Indeed, that's information for administrators, not for users.
Whiteboard: [easyconfirm][good first bug]
Someone on irc inquired today. Please contact me if you read this.

This link has some explanation and even covers SeaMonkey:
https://calomel.org/proxy_auto_config.html

And/or we link just to the wikipedia article:
https://en.wikipedia.org/wiki/Proxy_auto-config
Status: UNCONFIRMED → NEW
Ever confirmed: true

Hi, can I take it up as my first bug?

@Srujana Peddinti:
Thank you for your offer, of course.
If you need advice and /or assistance, please follow hints on
https://wiki.mozilla.org/SeaMonkey/FAQ#How_To_Start_Contributing_Code
step by step.

For any difficulties please do step 5 and ask for help in Newsgroup mozilla.dev.apps.seamonkey (or mailinglist)

You also might find some helpful hints in latest FIXED help/documentation bugs from https://bugzilla.mozilla.org/buglist.cgi?list_id=14597653&resolution=FIXED&classification=Client%20Software&chfieldto=Now&query_format=advanced&chfield=resolution&chfieldfrom=2016-01-01&chfieldvalue=FIXED&bug_status=RESOLVED&bug_status=VERIFIED&component=Help%20Documentation&product=SeaMonkey

Keywords: good-first-bug
Whiteboard: [easyconfirm][good first bug] → [easyconfirm]

A draft patch which adds a very, very brief explanation of PAC files and replaces the End User Guide link with the MDN one. Would this look acceptable?

Comment on attachment 9147816 [details] [diff] [review]
cs_nav_prefs_advanced.xhtml: replace PAC end user guide link, v1

Look fine to me. Best ask for feedback or r? every time you have a patch. Might fall thru a crack otherwise.
Attachment #9147816 - Flags: review?(iann_bugzilla)
Attachment #9147816 - Flags: feedback+
Assignee: nobody → nunojsg
Status: NEW → ASSIGNED
Comment on attachment 9147816 [details] [diff] [review]
cs_nav_prefs_advanced.xhtml: replace PAC end user guide link, v1

LGTM r/a=me

[Triage Comment]
Attachment #9147816 - Flags: review?(iann_bugzilla)
Attachment #9147816 - Flags: review+
Attachment #9147816 - Flags: approval-comm-release+
Attachment #9147816 - Flags: approval-comm-esr60+

Hi, are you working on which locales also need this fix?

Flags: needinfo?(nunojsg)

For the ones that have cs_nav_prefs_advanced.xhtml in English, I can do the same as the non-l10n patch. For locales with translated help, should I make a patch that just swaps the link, without touching the surrounding text?

(In reply to Nuno Silva from comment #10)

For the ones that have cs_nav_prefs_advanced.xhtml in English, I can do the same as the non-l10n patch. For locales with translated help, should I make a patch that just swaps the link, without touching the surrounding text?

Yes, please, I think that should be the starting point.

A starting point patch :-)

Hungarian had the PAC End User Guide title both in English and Hungarian, so this removes that Hungarian title translation and adds the new title only in English.

Flags: needinfo?(nunojsg)
Attachment #9149990 - Flags: feedback?(iann_bugzilla)

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e43591416144
Reword text about proxy auto-configuration and replace dead link. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Comment on attachment 9149990 [details] [diff] [review]
cs_nav_prefs_advanced.xhtml: remove PAC end user guide link l10n patch, v1

[Triage Comment]
LGTM r/a=me
Attachment #9149990 - Flags: review+
Attachment #9149990 - Flags: feedback?(iann_bugzilla)
Attachment #9149990 - Flags: approval-comm-release+
Attachment #9149990 - Flags: approval-comm-esr60+
Keywords: good-first-bug
Whiteboard: [easyconfirm] → SM2.53.3
You need to log in before you can comment on or make changes to this bug.