126713 - install FreeType2 on Linux/Unix build systems to enable TrueType in client

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[kill this account]

The TrueType Linux/Unix support code added in bug 116147 requires the
FreeType2 library to be on the build machine. 

(To avoid breaking the builds, configure checks if the lib is there and
if not disables the code.)

To make this code available to users we will need to install FreeType2
(at least the headers) on the appropiate build systems.

Comment 1

[hacker formerly known as [e-mail]]

Umm, doesn't this bring in the problem of an additional runtime dependency? 
Unless you're talking about statically linking against libfreetype which we
currently don't do.

Comment 2

[Chris McAfee]

can we do a dlopen at runtime and enable/disable accordingly?

Comment 3

[kill this account]

There are 3 "off" switches for this code:

 1) at compile time if the headers and libs are not on the build system
    the MOZ_ENABLE_FREETYPE2 define is not set and the code is #ifdef'd
    out.

 2) At run time if PR_LoadLibrary fails to load libfreetype.so then 
    the code is never called.

 3) There is a pref to enable this (off by default).

Comment 4

[kill this account]

Aki installed FreeType 2.0.4 on the SeaMonkey tinderbox system Comet yesterday
at about 5pm.

Comment 5

[Aki Sasaki]

installed on autobahn and bawb.  touched configure and configure.in on
autobahn's depend and clobber tinderboxen... we'll see if that's enough to
trigger it to reconfigure.

Comment 6

[Yuying Long]

-> nsbeta1

Comment 7

[Aki Sasaki]

In the configure, we're running

gcc -o conftest  -pthread -I/usr/local/include/freetype2   -I/usr/X11R6/include
 conftest.c -L/usr/local/lib -lfreetype -ldl -lm  -lc 1>&5

But we're getting 

./conftest: error in loading shared libraries: libfreetype.so.6: cannot open
shared object file: No such file or directory

And it's there:

bawb /builds/client/linux22/seamonkey/mozilla % ls -l /usr/local/lib
total 2096
-rw-r--r--    1 root     root      1363116 Feb 25 11:46 libfreetype.a
-rwxr-xr-x    1 root     root          726 Feb 25 11:46 libfreetype.la*
lrwxrwxrwx    1 root     root           20 Feb 25 11:46 libfreetype.so ->
libfreetype.so.6.1.0*
lrwxrwxrwx    1 root     root           20 Feb 25 11:46 libfreetype.so.6 ->
libfreetype.so.6.1.0*
-rwxr-xr-x    1 root     root       768530 Feb 25 11:46 libfreetype.so.6.1.0*

Manually setting the LD_LIBRARY_PATH to include /usr/local/lib is a workaround.

Comment 8

[Mike Shaver (:shaver emeritus)]

Either using LD_LIBRARY_PATH or adding /usr/local/lib to ld.so.conf isn't a
workaround, it's a solution: you're asking Mozilla to check libraries that
aren't in your default runtime linker path, so you're going to need to help it
find them.

Comment 9

[Aki Sasaki]

ok, putting in softlinks to /usr/local/lib/libfreetype.so.6.1.0 in /usr/lib gets
the configure working.

Comment 10

[kill this account]

TrueType now available in linux x86 mozilla and netscape

on to other platforms

Comment 11

[Aki Sasaki]

installed on como, messina, palermo, salerno... had to build with
/tools/ns/bin/gcc because ansic was too strict and it wouldn't build.
should show up next cycle, as they're all clobber builds.
torino isn't letting me in... seems hung.

Comment 12

[Aki Sasaki]

salerno has gone red because of freetype2... not sure if y'all want me to back
out or if you want a shot at fixing the problem first.

Comment 13

[kill this account]

would it be okay if we look at in the morning?

Comment 14

[Jim Dunn]

for hpux 10.20 & 11.00 why don't we get freetype from
http://hpux.connect.org.uk/hppd/hpux/Development/Libraries/freetype-2.0.6/

Unfortunately IBM's is only at 1.31 :-(
http://www-1.ibm.com/servers/aix/products/aixos/linux/download.html
(but the aix tinderbox isn't even working so no big deal there)

The only issue now is that the libs will be in a different place than
/usr/local for hpux & aix...

Comment 15

[kill this account]

> The only issue now is that the libs will be in a different place than
> /usr/local for hpux & aix...

The configure.in script uses AC_CHECK_FT2 from the FreeType2 freetype2.m4
script which uses 'freetype-config --libs' to find the libs.

Does the command 'freetype-config --libs' report the correct location?

If so the moz should find it.

Comment 16

[kill this account]

> for hpux 10.20 & 11.00 why don't we get freetype from ...

As long as 'freetype-config --version' reports at least 6.1.0 this should
be okay.

Comment 17

[Jim Dunn]

I am updating the HP machines right now using "connect's"
prebuilt libs (and it the version is > 6.1.0)
I updated the path on salerno (commercial) and restarted
the tinderbox.

Comment 18

[Jim Dunn]

Attachment: HP-UX patch

Here is the fix for hp-ux commercial (--enable-debug) tinderbox

Comment 19

[Jim Dunn]

Attachment: don't hardcode libfreetype.so, hardcode libfreetype$MOZ_DLL_SUFFIX

On HP, the sharedlib suffix is .sl, not .so
so we should never hardcode .so.

By putting in "libfreetype" MOZ_DLL_SUFFIX;
the preprocessor will do the correct thing.

NOTE, one or 2 of the bsd's in configure define MOZ_DLL_SUFFIX 
to .so.<something>   I can't do anything about that.

Comment 20

[kill this account]

Aki/Jim: Can we list all the machines that FreeType was installed on?

Comment 21

[Aki Sasaki]

see comment #4, comment #5, comment #11 for my installs.

Comment 22

[Jim Dunn]

HP-UX update:
I installed/reinstalled freetype2 on messina, como, pisa, salerno, palermo
which I got from 
http://hpux.connect.org.uk/hppd/hpux/Development/Libraries/freetype-2.0.6/
this puts the package in /opt/freetype.
Development:
  -You need to link/copy /opt/freetype/include/ft2build.h into /usr/include
  -Have /opt/freetype/bin in your path
Runtime:
  -Have /opt/freetype/lib in your SHLIB_PATH

Comment 23

[kill this account]

I suggest we implement jdunn's suggestion (via private AIM channel) and do 
something like this:

 if (!PR_LoadLibrary(libfreetype$MOX_DLL_SUFFIX)
    if (!PR_LoadLibrary(gFreeTypePrefName)
      ...

Comment 24

[Jim Dunn]

Do we also want to check in the "mozilla" script
if freetype-config is in $PATH, and if so add
`freetype-config --prefix`/libs to our 
LD_LIBRARY_PATH/SHLIB_PATH/LIBPATH?

Using --prefix seems simpler than using --libs and
having to "| awk '{print $1}' | cut <remove -L>"

Comment 25

[Jim Dunn]

err... ignore comment #24
chances are script will only be on machines that have
the freetype-development package on it, most users
(I suspect) will just install the freetype runtime package
so this change isn't probably worth the effort.

Comment 26

[Frank Tang]

take out nsbeta1 since this is a library instation issue.

Comment 27

[kill this account]

move target to 1.1

Comment 28

[Richard Biddle]

Could i please get some confirmation whether True type font support was added to
the Linux Mozilla 0.9.9 release.  The release notes say that it is but with
NS_FONT_DEBUG=400 I get "freetype not compiled in, nsFreeType.cpp 65".
Can the release notes please be altered to reflect this?
Thanks

Comment 29

[Aki Sasaki]

=P
Wasn't built in to the 0.9.9 binaries... I added the libs to the trunk build
machines early on, but we use different machines for the branch.

Comment 30

[Chris McAfee]

We always ship from a branch.  Can we get these libs installed on
the branch machines as well?

Comment 31

[Dawn Endico]

aki, would you respin the branch builds

Comment 32

[mair]

Could somebody please point out which if any 0.9.9 packages that have
TrueType/Freetype support built in?
I'm getting tired of stressing moz's ftp and re-re-re-installing to no avail...

Comment 33

[Aki Sasaki]

installed on goldie, respinning 0.9.9 linux build.

Comment 34

[Aki Sasaki]

also installed on foxhound.

Comment 35

[Aki Sasaki]

0.9.9 rereleased with freetype2.

Comment 36

[Thomas Swan]

Any chance the RedHat 7x RPMS will include freetype support?

Comment 37

[kill this account]

Thomas: you will need to contact Redhat about that.
Perhaps blizzard knows.

Comment 38

[kill this account]

Marking closed.
This has been done for a long time

Comment 39

[Yuying Long]

Mark as verified - enable True Type is availible from client now.

Comment 40

[kill this account]

take the "(in progress)" comment out of the title.