1267309 - Disallow embedded speech control commands in synthesized text

Status: RESOLVED FIXED

(Core :: Web Speech, defect)

Description

[Eitan Isaacson [:eeejay]]

OSX has its own set of speech commands that can be embedded in the synthesized text. We should disallow any command from executing, and we should simply read the text as-is.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: MozReview Request: Bug 1267309 - Escape embedded speech command delimiters. r?m_kato

Review commit: https://reviewboard.mozilla.org/r/49321/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49321/

Comment 2

[Eitan Isaacson [:eeejay]]

Comment on attachment 8746228 [details]
MozReview Request: Bug 1267309 - Escape embedded speech command delimiters. r?m_kato

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49321/diff/1-2/

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8746228 [details]
MozReview Request: Bug 1267309 - Escape embedded speech command delimiters. r?m_kato

https://reviewboard.mozilla.org/r/49321/#review46283

::: dom/media/webspeech/synth/cocoa/OSXSpeechSynthesizerService.mm:28
(Diff revision 2)
>  using namespace mozilla;
>  
>  class SpeechTaskCallback final : public nsISpeechTaskCallback
>  {
>  public:
> -  SpeechTaskCallback(nsISpeechTask* aTask, NSSpeechSynthesizer* aSynth)
> +  SpeechTaskCallback(nsISpeechTask* aTask, NSSpeechSynthesizer* aSynth, nsTArray<size_t>& aOffsets)

nit: SpeechTaskCallback(..., const nsTArray<size_t>& aOffsets).

::: dom/media/webspeech/synth/cocoa/OSXSpeechSynthesizerService.mm:401
(Diff revision 2)
>      [synth setObject:[NSNumber numberWithInt:newPitch]
>             forProperty:NSSpeechPitchBaseProperty error:nil];
>    }
>  
> -  RefPtr<SpeechTaskCallback> callback = new SpeechTaskCallback(aTask, synth);
> +  nsAutoString escapedText;
> +  nsTArray<size_t> offsets;

add the following to reduce reallocation.
offsets.SetCapacity(aText.Length());

Comment 4

[Eitan Isaacson [:eeejay]]

Comment on attachment 8746228 [details]
MozReview Request: Bug 1267309 - Escape embedded speech command delimiters. r?m_kato

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49321/diff/2-3/

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/efb687e87f74

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/efb687e87f74