1268633 - Enable synth API outside of desktop Nightly

Status: RESOLVED FIXED

(Core :: Web Speech, defect)

Description

[Eitan Isaacson [:eeejay]]

Currently speech synthesis is available in nightly only. This bug will track the blockers, and ultimately offer a patch for enabling synth everywhere on desktop.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1268633 - Let speech synthesis ride the trains.

Review commit: https://reviewboard.mozilla.org/r/57238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57238/

Comment 2

[Eitan Isaacson [:eeejay]]

Once the SpeechSynthesisErrorEvent bug lands, I think we should turn this puppy on! Hopefully before the next merge..

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

So we have sorted out all those issues that we were supporting some OS dependent syntax for SpeechSynthesisUtterance? Now only text or SSML is supported, right?

Comment 4

[Eitan Isaacson [:eeejay]]

1237546

Comment 5

[Eitan Isaacson [:eeejay]]

(In reply to Olli Pettay [:smaug] (high review load, please consider other reviewers) from comment #3)
> So we have sorted out all those issues that we were supporting some OS
> dependent syntax for SpeechSynthesisUtterance? Now only text or SSML is
> supported, right?

We don't support SSML intentionally until we get it right and secure on all platforms.

Embedded speech commands are disabled in windows (bug 1237546), and mac (bug 1267309). In linux it was disabled all along (there is SSML support that is disabled by default).

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8759240 [details]
Bug 1268633 - Let speech synthesis ride the trains.

https://reviewboard.mozilla.org/r/57238/#review54634

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01108bd8a50f
Let speech synthesis ride the trains. r=smaug

Comment 8

[Eitan Isaacson [:eeejay]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Firefox 49 is the first version to have our speech synthesis API preffed on.
[Suggested wording]: Introduced web speech synthesis API.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/Web_Speech_API

*note* This is only the synthesis half of the speech API, not the recognition.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/01108bd8a50f

Comment 10

[Eitan Isaacson [:eeejay]]

Attachment: 8875462.txt

Jonas rs'ed this in-channel with the build sherrif. But I'm getting your retrospective approval in case you want us to back this out.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8760533 [details] [diff] [review]
8875462.txt

oh, Android is still false.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b7ef5d019be
followup, adjust test_interfaces.html to expect that the SpeechSynthesis API is riding the trains. r=smaug

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b7ef5d019be

Comment 14

[Chris Mills [:cmills]]

I've updated all the relevant browser compat tables underneath the https://developer.mozilla.org/en-US/docs/Web/API/Web_Speech_API docs, and added a note in the relevant release notes:

https://developer.mozilla.org/en-US/docs/Web/API/Web_Speech_API

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Added to the release notes with Eitan's wording