Closed Bug 1268633 Opened 5 years ago Closed 5 years ago

Enable synth API outside of desktop Nightly

Categories

(Core :: Web Speech, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed
relnote-firefox --- 49+

People

(Reporter: eeejay, Assigned: eeejay)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Currently speech synthesis is available in nightly only. This bug will track the blockers, and ultimately offer a patch for enabling synth everywhere on desktop.
Summary: Enable synth API outside of Nightly → Enable synth API outside of desktop Nightly
Blocks: 1166365
Depends on: 1258526
Depends on: 1178738
Depends on: 1238522, 1248206
Once the SpeechSynthesisErrorEvent bug lands, I think we should turn this puppy on! Hopefully before the next merge..
So we have sorted out all those issues that we were supporting some OS dependent syntax for SpeechSynthesisUtterance? Now only text or SSML is supported, right?
1237546
Depends on: 1267309
(In reply to Olli Pettay [:smaug] (high review load, please consider other reviewers) from comment #3)
> So we have sorted out all those issues that we were supporting some OS
> dependent syntax for SpeechSynthesisUtterance? Now only text or SSML is
> supported, right?

We don't support SSML intentionally until we get it right and secure on all platforms.

Embedded speech commands are disabled in windows (bug 1237546), and mac (bug 1267309). In linux it was disabled all along (there is SSML support that is disabled by default).
No longer depends on: 1178738
Attachment #8759240 - Flags: review?(bugs) → review+
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01108bd8a50f
Let speech synthesis ride the trains. r=smaug
Release Note Request (optional, but appreciated)
[Why is this notable]: Firefox 49 is the first version to have our speech synthesis API preffed on.
[Suggested wording]: Introduced web speech synthesis API.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/Web_Speech_API

*note* This is only the synthesis half of the speech API, not the recognition.
relnote-firefox: --- → ?
https://hg.mozilla.org/mozilla-central/rev/01108bd8a50f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Attached patch 8875462.txtSplinter Review
Jonas rs'ed this in-channel with the build sherrif. But I'm getting your retrospective approval in case you want us to back this out.
Attachment #8760533 - Flags: review?(bugs)
Comment on attachment 8760533 [details] [diff] [review]
8875462.txt

oh, Android is still false.
Attachment #8760533 - Flags: review?(bugs) → review+
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b7ef5d019be
followup, adjust test_interfaces.html to expect that the SpeechSynthesis API is riding the trains. r=smaug
I've updated all the relevant browser compat tables underneath the https://developer.mozilla.org/en-US/docs/Web/API/Web_Speech_API docs, and added a note in the relevant release notes:

https://developer.mozilla.org/en-US/docs/Web/API/Web_Speech_API
Added to the release notes with Eitan's wording
You need to log in before you can comment on or make changes to this bug.