Closed
Bug 1267577
Opened 8 years ago
Closed 8 years ago
B2GOS: Move nsRunnable to mozilla::Runnable
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox49 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: gwagner, Assigned: gwagner)
References
Details
Attachments
(1 file)
84.14 KB,
patch
|
gsvelto
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8745273 -
Flags: review?(gsvelto)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → anygregor
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f381918577294affef97c808e3359c5bb80d1d8f
Comment 4•8 years ago
|
||
Comment on attachment 8745273 [details] [diff] [review] patch Pretty straightforward, looks good to me. On a side note I've noticed this only reference left in what looks like our code: https://dxr.mozilla.org/mozilla-central/source/dom/tv/TVServiceRunnables.h#26 You might want to adjust it to if it's relevant.
Attachment #8745273 -
Flags: review?(gsvelto) → review+
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to Gabriele Svelto [:gsvelto] from comment #4) > Comment on attachment 8745273 [details] [diff] [review] > patch > > Pretty straightforward, looks good to me. > > On a side note I've noticed this only reference left in what looks like our > code: > > https://dxr.mozilla.org/mozilla-central/source/dom/tv/TVServiceRunnables.h#26 > > You might want to adjust it to if it's relevant. I was thinking about it but I don't like fixing code that doesn't get compiled.
Josh, please see comment 6; I'm not sure if this is applicable for your TV team. Just a FYI to Gregor, I was able to build aries off of mozilla-inbound again.
Flags: needinfo?(jocheng)
Comment 8•8 years ago
|
||
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #7) > Josh, please see comment 6; I'm not sure if this is applicable for your TV > team. > > Just a FYI to Gregor, I was able to build aries off of mozilla-inbound again. Thanks Naoki, we have branched out 2.6 for TV thus it does not affect TV
Flags: needinfo?(jocheng)
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/03b88e129a66
You need to log in
before you can comment on or make changes to this bug.
Description
•