1267577 - B2GOS: Move nsRunnable to mozilla::Runnable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f381918577294affef97c808e3359c5bb80d1d8f

Comment 4

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8745273 [details] [diff] [review]
patch

Pretty straightforward, looks good to me.

On a side note I've noticed this only reference left in what looks like our code:

https://dxr.mozilla.org/mozilla-central/source/dom/tv/TVServiceRunnables.h#26

You might want to adjust it to if it's relevant.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03b88e129a66

Comment 6

[Gregor Wagner [:gwagner]]

(In reply to Gabriele Svelto [:gsvelto] from comment #4)
> Comment on attachment 8745273 [details] [diff] [review]
> patch
> 
> Pretty straightforward, looks good to me.
> 
> On a side note I've noticed this only reference left in what looks like our
> code:
> 
> https://dxr.mozilla.org/mozilla-central/source/dom/tv/TVServiceRunnables.h#26
> 
> You might want to adjust it to if it's relevant.

I was thinking about it but I don't like fixing code that doesn't get compiled.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Josh, please see comment 6; I'm not sure if this is applicable for your TV team.
 
Just a FYI to Gregor, I was able to build aries off of mozilla-inbound again.

Comment 8

[Josh Cheng [:josh]]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #7)
> Josh, please see comment 6; I'm not sure if this is applicable for your TV
> team.
>  
> Just a FYI to Gregor, I was able to build aries off of mozilla-inbound again.

Thanks Naoki, we have branched out 2.6 for TV thus it does not affect TV

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/03b88e129a66