1265927 - Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

This is largely mechanical.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

fyi comm-central will need some simple adjustments here.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8743051 [details] [diff] [review]
Patch

Review of attachment 8743051 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to assume this was essentially:

find . -name \*.h | xargs perl -pie 's/\bnsRunnable\b/mozilla::Runnable/g'
find . -name \*.cpp | xargs perl -pie 's/\bnsRunnable\b/Runnable/g'

with a bit of smarts on the header side to not add qualifiers when necessary.  Picking a couple of files at random suggests this is the case.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

It was a little more complicated than that, but yeah, that's pretty much what it was.

Comment 4

[Edmund Wong (:ewong)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #1)
> fyi comm-central will need some simple adjustments here.

Thanks Kyle for the heads-up!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcc0936b576d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fcc0936b576d

Comment 7

[Alessio Placitelli [:Dexter]]

Hi Nathan!

Sorry to uncover this old bug, but does the changes here imply that the docs at [1] (and other places?) need to be updated?

[1] - https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Guide/Cross-thread_calls_using_runnables

Comment 8

[Nathan Froyd [:froydnj]]

(In reply to Alessio Placitelli [:Dexter] from comment #7)
> Sorry to uncover this old bug, but does the changes here imply that the docs
> at [1] (and other places?) need to be updated?

Yes!  Thanks for ferreting that out.

Comment 9

[Alessio Placitelli [:Dexter]]

(In reply to Nathan Froyd [:froydnj] from comment #8)
> (In reply to Alessio Placitelli [:Dexter] from comment #7)
> > Sorry to uncover this old bug, but does the changes here imply that the docs
> > at [1] (and other places?) need to be updated?
> 
> Yes!  Thanks for ferreting that out.

Cool! Who is going to do that? Should we simply mark this with dev-doc-needed?

Comment 10

[Nathan Froyd [:froydnj]]

(In reply to Alessio Placitelli [:Dexter] from comment #9)
> (In reply to Nathan Froyd [:froydnj] from comment #8)
> > (In reply to Alessio Placitelli [:Dexter] from comment #7)
> > > Sorry to uncover this old bug, but does the changes here imply that the docs
> > > at [1] (and other places?) need to be updated?
> > 
> > Yes!  Thanks for ferreting that out.
> 
> Cool! Who is going to do that? Should we simply mark this with
> dev-doc-needed?

I know that's what you do for web-facing things; I'm less certain about what to do for Gecko internals.  I will put this on my list of things to do.  Thanks!