Closed
Bug 1267675
Opened 10 years ago
Closed 10 years ago
gaia shared IconsHelper doesn't handle lack of datastore
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cwiiis, Assigned: cwiiis)
References
Details
Attachments
(1 file)
If you try to fetch an icon using IconsHelper, it will fail because datastore is no longer available. There are comments in the code that say it should still fetch the icon, but it doesn't.
Of course we should get it to stop using datastore too, but we should also fix the error handling. This bug is about the latter.
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8745385 [details] [review]
[gaia] Cwiiis:fix-iconshelper-error-handling > mozilla-b2g:kanikani
There may be other functions that are still broken, I didn't audit the file - this is enough to make homescreen work.
Attachment #8745385 -
Flags: review?(apastor)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8745385 [details] [review]
[gaia] Cwiiis:fix-iconshelper-error-handling > mozilla-b2g:kanikani
LGTM. Thanks!
Attachment #8745385 -
Flags: review?(apastor) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•