1267690 - Transparency black/flickering in Vimeo icons

Status: RESOLVED DUPLICATE of bug 1269321

(Core :: Graphics, defect)

Description

[Mike Hoye [:mhoye]]

See this URL: https://vimeo.com/157712307

The round icons next to the comments have black corners in Nightly, as compared to them correctly being displayed as circles in Aurora. Oddly, when you scroll the icons display correctly, but when you stop the black corners are drawn.

Very oddly, if you play the video for a while while the tab is in the background, some of the time if you come back to the tab the corners of those icons will be flickering very rapidly.

Comment 1

[Benjamin Smedberg]

[Tracking Requested - why for this release]:

I can reproduce on Windows.

Comment 2

[Alice0775 White]

FYI,
layout.css.prefixes.webkit = false fixes the problem

Comment 3

[Alice0775 White]

[Tracking Requested - why for this release]:

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f44d3d568c2dd57365c85e70f9fd96db62ad5749&tochange=4d4dd7869c4fc912a2f9f8fb9ce37db76051d1c5

Regressed by:
4d4dd7869c4f	Thinker K.F. Li — Bug 1244943 - Make PostProcessLayers aware of preserve-3d. r=mattwoodrow

Comment 4

[Marcia Knous [:marcia]]

Tracking for 48 and 49. ni on Thinker as Comment 3 as his patch is in the regression window - Thinker can you take a look? Thanks!

Comment 5

[Thinker Li [:sinker]]

I have did a simple test.  Icons are good at first sight, and corners turn black after scrolling.  I will look into it ASAP.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking Thinker as the assignee based on comment 5 :)

Comment 7

[Thinker Li [:sinker]]

Attachment: Skip opaque for extend3d layers with mask layers

Comment 8

[Thinker Li [:sinker]]

Hi Mike, could you check the patch to make sure it has fixed the problem?

Comment 9

[Thinker Li [:sinker]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e7d257206a4

Comment 10

[Mike Hoye [:mhoye]]

Sorry for the delay. Rebuilding shortly, will get back to you this evening.

Comment 11

[Milan Sreckovic [:milan] (needinfo for best results)]

Yes, it'd be good if we can land and uplift this while 48 is still in Aurora, so let's get the reviews going while waiting to confirm the fix.

Comment 12

[Mike Hoye [:mhoye]]

With this patch applied, I can still see black outlines flickering on scroll. They don't stay anymore when scrolling stops, but they're definitely still flickering visibly during scrolling.

Comment 13

[Mike Hoye [:mhoye]]

Nope; after moving away from the window and moving back - scrolling but not focusing on the window - I can still reproduce the black-square effect.

Comment 14

[Thinker Li [:sinker]]

Mike, what the environment are you testing in?

Comment 15

[Thinker Li [:sinker]]

Is there any other people who can reproduce the problem encountered by Mike Hoye?
I don't know how to reproduce it.

Comment 16

[Mike Hoye [:mhoye]]

I'm on OSX, current latest and dual monitor. I'll re-verify today.

Comment 17

[Mike Hoye [:mhoye]]

With the patch applied, I can no longer reproduce this on either windows or OSX. Sorry for the confusion, I must have screwed up something earlier.

Comment 18

[Thinker Li [:sinker]]

Mike, Thank you for the comments.

Comment 19

[Thinker Li [:sinker]]

Comment on attachment 8752089 [details] [diff] [review]
Skip opaque for extend3d layers with mask layers

Review of attachment 8752089 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Matt, would you review this patch?

Comment 20

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8752089 [details] [diff] [review]
Skip opaque for extend3d layers with mask layers

Review of attachment 8752089 [details] [diff] [review]:
-----------------------------------------------------------------

Having Extend3DContext() and a mask on the same layer is fundamentally broken, and can't render correctly for non-trivial (2d) transforms.

Does the patch queue in bug 1269321 fix this?

Comment 21

[Milan Sreckovic [:milan] (needinfo for best results)]

If we're going to fix this in 48, now is the time to figure out what to do.

Comment 22

[Thinker Li [:sinker]]

As Matt had mentioned, this bug should be fixed by the patch queue in bug 1269321.  Although it is still not landed, however, the problem has gone with m-c and 48.  So, I need some one other me to confirm it.

Mike Hoye, is the problem still there with m-c and 48?

Comment 23

[Mike Hoye [:mhoye]]

Nope, I can't reproduce this on current nightly at all.

Comment 24

[Milan Sreckovic [:milan] (needinfo for best results)]

Given the mystery around it, chances are we won't be "uplifting" this to 48 - though it may already be somehow fixed, I will still mark it wontfix for 48.

Comment 25

[Milan Sreckovic [:milan] (needinfo for best results)]

I'm going to call this fixed by bug 1269321, given comment 22 and comment 23.