Closed Bug 1244943 Opened 4 years ago Closed 4 years ago

Make LayerManagerComposite::PostProcessLayers understand preserve-3d

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox46 + fixed
firefox47 + fixed

People

(Reporter: mattwoodrow, Assigned: sinker)

References

Details

(Keywords: regression, Whiteboard: [gfx-noted])

Attachments

(1 file, 1 obsolete file)

Bug 1229317 is making this code bail out from it's attempts to minimize the visible region if any children have preserve-3d.

We should be able to handle these layers properly, probably by passing a reference to the visible region being accumulated for the ancestor of the preserve-3d tree down to the leaves and transforming by the accumulated transform.
Comment on attachment 8716248 [details] [diff] [review]
Make PostProcessLayers aware of preserve-3d

This patch treat a layers on the path to the root of a 3D rendering context as a giant layer.  So, it skips all intermediate layers, and use accumulated transforms for the leaves of 3d rendering context.
Attachment #8716248 - Flags: feedback?(matt.woodrow)
Comment on attachment 8716248 [details] [diff] [review]
Make PostProcessLayers aware of preserve-3d

Review of attachment 8716248 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this is exactly what I had in mind!

End up being simpler than I imagined too, thanks for doing this.
Attachment #8716248 - Flags: feedback?(matt.woodrow) → feedback+
Whiteboard: [gfx-noted]
--
Attachment #8716248 [details] [diff] - Attachment is obsolete: true
Attachment #8720088 - Flags: review?(matt.woodrow)
Attachment #8716248 - Attachment is obsolete: true
Attachment #8720088 - Flags: review?(matt.woodrow) → review+
Looks like this may not have landed yet. It should probably get uplift to aurora 46 as well once it is on m-c for a bit.
Flags: needinfo?(wkocher)
Flags: needinfo?(tlee)
Landed to aurora:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4dd7869c4f

Will leave the uplift request to matt and :sinker
Flags: needinfo?(wkocher)
Comment on attachment 8720088 [details] [diff] [review]
Make PostProcessLayers aware of preserve-3d, v2

Approval Request Comment
[Feature/regressing bug #]: 1244943
[User impact if declined]: With incorrect visible region of layers, screen repainting is potentially wrong.
[Describe test coverage new/current, TreeHerder]:
Testcases of layer tree invalidation would cover this change.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9980d741547c
[Risks and why]: 
Low risk because it does not effect other features, and the change is limited in a small block in a function.
[String/UUID change made/needed]: none
Flags: needinfo?(tlee)
Attachment #8720088 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/4d4dd7869c4f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Marking affected for 46, tracking as this is a regression from the preserve-3d changes
Comment on attachment 8720088 [details] [diff] [review]
Make PostProcessLayers aware of preserve-3d, v2

Should help with preserve-3d changes, please uplift to aurora.
Attachment #8720088 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 1267690
Depends on: 1275213
You need to log in before you can comment on or make changes to this bug.