1244943 - Make LayerManagerComposite::PostProcessLayers understand preserve-3d

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Bug 1229317 is making this code bail out from it's attempts to minimize the visible region if any children have preserve-3d.

We should be able to handle these layers properly, probably by passing a reference to the visible region being accumulated for the ancestor of the preserve-3d tree down to the leaves and transforming by the accumulated transform.

Comment 1

[Thinker Li [:sinker]]

Attachment: Make PostProcessLayers aware of preserve-3d

Comment 2

[Thinker Li [:sinker]]

Comment on attachment 8716248 [details] [diff] [review]
Make PostProcessLayers aware of preserve-3d

This patch treat a layers on the path to the root of a 3D rendering context as a giant layer.  So, it skips all intermediate layers, and use accumulated transforms for the leaves of 3d rendering context.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8716248 [details] [diff] [review]
Make PostProcessLayers aware of preserve-3d

Review of attachment 8716248 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this is exactly what I had in mind!

End up being simpler than I imagined too, thanks for doing this.

Comment 4

[Thinker Li [:sinker]]

Attachment: Make PostProcessLayers aware of preserve-3d, v2

--
Attachment #8716248 [details] [diff] - Attachment is obsolete: true

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Looks like this may not have landed yet. It should probably get uplift to aurora 46 as well once it is on m-c for a bit.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4dd7869c4f

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Landed to aurora:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4dd7869c4f

Will leave the uplift request to matt and :sinker

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Er, landed to *inbound*.

Comment 9

[Thinker Li [:sinker]]

Comment on attachment 8720088 [details] [diff] [review]
Make PostProcessLayers aware of preserve-3d, v2

Approval Request Comment
[Feature/regressing bug #]: 1244943
[User impact if declined]: With incorrect visible region of layers, screen repainting is potentially wrong.
[Describe test coverage new/current, TreeHerder]:
Testcases of layer tree invalidation would cover this change.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9980d741547c
[Risks and why]: 
Low risk because it does not effect other features, and the change is limited in a small block in a function.
[String/UUID change made/needed]: none

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d4dd7869c4f

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking affected for 46, tracking as this is a regression from the preserve-3d changes

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8720088 [details] [diff] [review]
Make PostProcessLayers aware of preserve-3d, v2

Should help with preserve-3d changes, please uplift to aurora.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/31c2798b51d5