1267835 - Land version 1.3.1 of the Loop system add-on in mozilla-central

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Changelog: https://github.com/mozilla/loop/blob/release/CHANGELOG.md

Comment 1

[Mark Banner (:standard8)]

Attachment: Land version 1.3.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.

Comment 2

[Mark Banner (:standard8)]

Summary of changes:

- Stop the panel being able to be display in private browsing mode (bug 1261849)
- Stop listeners being duplicated when opening the panel (bug 1250849)
- Fixes for intermittent failures in tests

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b567617d9f02

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b567617d9f02

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8745616 [details] [diff] [review]
Land version 1.3.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello
[User impact if declined]: Users may be able to get into Hello in private browsing mode causing confusion (bug 1261849). This also fixes an issue with listeners being added multiple times (if Hello panel was used it a lot in one session it could cause visible slow-downs, but its probably not generally user visible).

Also fixes issues with intermittent/perma oranges.

[Describe test coverage new/current, TreeHerder]: Landed in m-c, panel code has various automatic tests.
[Risks and why]: Low, fixes issues in tests, very small localised changes for the panel.
[String/UUID change made/needed]: None

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8745616 [details] [diff] [review]
Land version 1.3.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.

Hello 1.3.1 uplift to Fx48, baked in Nightly for a week, Aurora48+

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0b8f7132ed6d

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8745616 [details] [diff] [review]
Land version 1.3.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello 1.3.2
[User impact if declined]: Firefox 47 users won't have the same version as Firefox 46.
[Describe test coverage new/current, TreeHerder]: Landed in central & aurora. Shipped via go faster to beta 47 and now release 46
[Risks and why]: Landing shipped code.
[String/UUID change made/needed]: None

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8745616 [details] [diff] [review]
Land version 1.3.1 of the Loop system add-on in mozilla-central, rs=Standard8 for already reviewed code.

Makes sense, Beta47+

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4c0231d73fd3

Comment 11

[Bogdan Maris, Desktop Test Engineering]

Based on our testing done using Firefox 47 beta 4 and Hello version 1.3.2 I think we can close this bug as verified.

For more details about our testing please see this gdoc: https://goo.gl/mKDa2R

I will also mark 48 and 49 as verified as well since there is a new version coming already.