126784 - removing site name(s) from Publish Site Settings does not remove from prefs (shows up in Publish to menu)

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[sujay]

using 2/20 trunk build on windows

1) launch netscape
2) launch composer
3) Publish two sites(giving it a site name, filename, username, passwd, etc..)

at this point you should have two publish site names in the "Publish To"
menu.

4) Now go into Edit | Publish Site settings and remove one of the sites
you added. and click OK on that panel

5) Now go back in your edit window and pull down File | Publish To
and notice that you still have two sites. should have only one.

and just in case setting changing the Pub Site settings is only for
a future instance, I also tried to Open a new blank page and I still
got two site names stuck in there...

I expect the site to be removed from the list.

Comment 1

[shrirang khanzode]

*test*..pls ignore

Comment 2

[Charles Manske]

Ohhh! Good catch. It only happens when you remove the "default" site.
We need to (arbitrarily) select a new default site if user does that.

Comment 3

[Charles Manske]

Attachment: Fix

Comment 4

[Charles Manske]

We rely heavily on the concept of having a 'default publishing site', so it's
important that we don't loose it accidentally like this bug does.

Comment 5

[Charles Manske]

Attachment: Updated fix

This adds additional safety: when saving the site data, assure that the 
default name is the site data -- if not, use the first sitename

Comment 6

[Charles Manske]

Comment on attachment 70633 [details] [diff] [review]
Updated fix

r=mjudge
Also discussed with brade, who approved the logic of the fix

Comment 7

[Charles Manske]

changing milestone

Comment 8

[Charles Manske]

I have a lot of changes to the publishing UI files that includes this fix.
I'll attach all as a patch to bug 88208, so the SR can be on that patch.

Comment 9

[sujay]

But charley, if this bug is fixed due to patch in another bug, make
sure you mark this bug fixed so we know when to verify it..thanks!

Comment 10

[kinmoz]

Comment on attachment 70633 [details] [diff] [review]
Updated fix

sr=[e-mail]

But make sure you change '==' to '=' in this part of the diff:

+      if (siteArray.length && !defaultFound)
+	 defaultName == siteArray[0].siteName;

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 70633 [details] [diff] [review]
Updated fix

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 12

[sujay]

is this bug fixed?...if so mark it RESOLVED-FIXED so we can verify it..

Comment 13

[sujay]

correcting summary

Comment 14

[Charles Manske]

checked in

Comment 15

[sujay]

Publish To is gone now with 88208 landing, so this bug is moot point.

however, I verified that removing site names from site settings
does remove from the site name list.

Comment 16

[Serge Gautherie (:sgautherie)]

Changing:
 *(H) Sun -> PC, per comment 0.
 *(OS) Windows 3.1 -> Windows 95.
(This will help on bug 165825 :-))