Closed Bug 126789 Opened 21 years ago Closed 21 years ago

Templatise token.cgi

Categories

(Bugzilla :: Bugzilla-General, defect)

2.15
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
Bugzilla 2.16

People

(Reporter: gerv, Assigned: gerv)

Details

Attachments

(1 file)

This one's pretty easy.

Gerv
Target Milestone: --- → Bugzilla 2.16
Attached patch PAtch v.1Splinter Review
Myk should definitely review this. I can't really test it as I have no idea how
it works :-) Do we even use this stuff?

Gerv
Myk - could you take a look at this?

Thanks.

Gerv
Assignee: justdave → gerv
Keywords: patch, review
Comment on attachment 70583 [details] [diff] [review]
PAtch v.1

looks good, works, r=bbaetz
Attachment #70583 - Flags: review+
Comment on attachment 70583 [details] [diff] [review]
PAtch v.1

This is OK, except the template should go in admin/users.
Attachment #70583 - Flags: review-
Actually, on second thoughts, is admin even the place for the template?
It doesn't really matter where it goes, because they are all going to be moved
and renamed at the end anyway :-)

Gerv
Matty: is that your only objection? Does this have r= otherwise?

Gerv
Is has r= otherwise.  I think it should go into "accounts", along with bug
#126908.  Possibly "accounts" should be a renamed "userprefs".
Checking in token.cgi;
/cvsroot/mozilla/webtools/bugzilla/token.cgi,v  <--  token.cgi
new revision: 1.5; previous revision: 1.4
done
Checking in template/default/admin/change-password.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/default/admin/change-password.html.tmpl,v
 <--  change-password.html.tmpl
initial revision: 1.1

Checked in. I'm not going to start creating new directories in template/default
at this stage - it'll all get rearranged later anyway. Let's get on with the
other patches and then we can do the rearranging.

Gerv
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.