126789 - Templatise token.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Gervase Markham [:gerv]]

This one's pretty easy.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: PAtch v.1

Myk should definitely review this. I can't really test it as I have no idea how
it works :-) Do we even use this stuff?

Gerv

Comment 2

[Gervase Markham [:gerv]]

Myk - could you take a look at this?

Thanks.

Gerv

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 70583 [details] [diff] [review]
PAtch v.1

looks good, works, r=bbaetz

Comment 4

[Matthew Tuck [:CodeMachine]]

Comment on attachment 70583 [details] [diff] [review]
PAtch v.1

This is OK, except the template should go in admin/users.

Comment 5

[Matthew Tuck [:CodeMachine]]

Actually, on second thoughts, is admin even the place for the template?

Comment 6

[Gervase Markham [:gerv]]

It doesn't really matter where it goes, because they are all going to be moved
and renamed at the end anyway :-)

Gerv

Comment 7

[Gervase Markham [:gerv]]

Matty: is that your only objection? Does this have r= otherwise?

Gerv

Comment 8

[Matthew Tuck [:CodeMachine]]

Is has r= otherwise.  I think it should go into "accounts", along with bug
#126908.  Possibly "accounts" should be a renamed "userprefs".

Comment 9

[Gervase Markham [:gerv]]

Checking in token.cgi;
/cvsroot/mozilla/webtools/bugzilla/token.cgi,v  <--  token.cgi
new revision: 1.5; previous revision: 1.4
done
Checking in template/default/admin/change-password.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/default/admin/change-password.html.tmpl,v
 <--  change-password.html.tmpl
initial revision: 1.1

Checked in. I'm not going to start creating new directories in template/default
at this stage - it'll all get rearranged later anyway. Let's get on with the
other patches and then we can do the rearranging.

Gerv