Closed Bug 126803 Opened 23 years ago Closed 23 years ago

[FIX]Cannot close print preview without error alert

Categories

(Core :: Print Preview, defect)

Product:
Core
Component:
Print Preview
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.9

People

(Reporter: bzbarsky, Assigned: rods)

References

Details

(Keywords: access)

Attachments

(1 file)

patch
2.51 KB, patch
dcone
: review+
attinasi
: superreview+
Details | Diff | Splinter Review 
BUILD: Linux 2002-02-20-08

STEPS TO REPRODUCE:
1)  Open print preview
2)  Click close button

EXPECTED RESULT: Print preview closes

ACTUAL RESULT: An alert comes up, saying "Some printing functionality is not
implemented yet."

NOTE: This is the alert that gets shown for NS_ERROR_NOT_IMPLEMENTED,
      apparently.  Why is something throwing that when we _close_ print preview?
See comments in bug 126427.  It could be that the PrintData destructor is
triggering this....
This is originating in the backend.  Over to Rod for a look.
Assignee: sgehani → rods
Blocks: 126800
*** Bug 126800 has been marked as a duplicate of this bug. ***
Dup is an accessibility bug...
Keywords: access
Boris, can you tell me where this is coming from? Who is generating the
"NS_ERROR_NOT_IMPLEMENTED"?
Status: NEW → ASSIGNED
Keywords: nsbeta1
Target Milestone: --- → mozilla0.9.9
Sure thing.

PrintData::~PrintData calls mPrintDC->EndDocument(); which returns
NS_ERROR_NOT_IMPLEMENTED

In fact, a bunch of the nsDeviceContextGTK functions (EndDocument,
BeginDocument, AbortDocument, BeginPage, EndPage) do that.  You may want to just
special-case this one spot, I guess...  Check that it's not
NS_ERROR_NOT_IMPLEMENTED before throwing the dialog.
Attached patch patch — — Splinter Review 
It is not an error to not have implemented these, they are merely a no-op
Comment on attachment 70801 [details] [diff] [review]
patch

r=dcone
Attachment #70801 - Flags: review+
Comment on attachment 70801 [details] [diff] [review]
patch

sr=attinasi
Attachment #70801 - Flags: superreview+
Marking nsbeta1+
Keywords: nsbeta1 → nsbeta1+
Summary: Cannot close print preview without error alert → [FIX]Cannot close print preview without error alert
a=asa (on behalf of drivers) for checkin to 0.9.9
Keywords: mozilla0.9.9+
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Boris, this should be working for you now in today's builds...can you please 
check ? thanks..
yep.  working in cvs pull from last night and today's nightly.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: