1268462 - [gtk3] Not consistent submenu popup back ground color. And menu highlight is invisible

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alice0775 White]

Attachment: screenshot

Since Firefox46. Submenu color is broken on Ubuntu14.04 default theme.
See screenshot.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

I think it's caused by mixed internal and system (gtk) menus in Firefox. The bookmarks, settings, download pop-ups are rendered by Firefox internal css colors but menus are rendered by gtk with system color. It think internal popups can't be mixed with system widgets.

As you can see even the first picture (with the same menu color) has a different sub-menu style. The sub-menu is shadowed and "behind" the firefox menu.

IMHO the fix would be to convert the submenu to Firefox internal one.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

> different sub-menu style. The sub-menu is shadowed and "behind" the firefox
> menu.

Ehh, sorry, the shadowed system menu is in front of the Firefox one.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Recent regression, tracking. 
Unlikely to be fixed in 46 though.

Comment 4

[Alice0775 White]

Attachment: Light theme suchas "Radiance"

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 8752622 [details]
Light theme suchas "Radiance"

This looks like it may be bug 1269523.

Comment 6

[Karl Tomlinson (:karlt)]

(In reply to Karl Tomlinson (ni?:karlt) from comment #5)
> Comment on attachment 8752622 [details]
> Light theme suchas "Radiance"
> 
> This looks like it may be

bug 1272194, I mean.

Comment 7

[Alice0775 White]

(In reply to Karl Tomlinson (ni?:karlt) from comment #6)
> (In reply to Karl Tomlinson (ni?:karlt) from comment #5)
> > Comment on attachment 8752622 [details]
> > Light theme suchas "Radiance"
> > 
> > This looks like it may be
> 
> bug 1272194, I mean.

I can still reproduce.
Goodbye, Firefox.

https://hg.mozilla.org/mozilla-central/rev/3435dd7ad71fe9003bdeee18fd38d815e033beef
Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0 ID:20160530071207

Comment 8

[Karl Tomlinson (:karlt)]

(In reply to Alice0775 White from comment #7)
> 3435dd7ad71fe9003bdeee18fd38d815e033beef
> Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0
> ID:20160530071207

Attachment 8752622 [details] is not reproducing for me with that build and Radiance.

Attachment 8746505 [details] is still reproducing with Ambiance.

Comment 9

[Justin Dolske [:Dolske]]

If attachment 8746505 [details] is the remaining issue here, this sounds a lot like an existing/older (fixed?) bug with the mix of pseudo-menuitems in the <panel> being mixed with the actual <menu> submenus... I'm not sure I understand why it ever worked before?

Gijs, suggestions on what the fix here should be? Is this a front-end issue, or problem with how GTK3 menu styles are being picked up?

Comment 10

[Rakhi(:rakhisharma)]

I think the behavior of gtk code  is responsible for this issue. The implementation of the -moz-appearance rule is in GTK code in Firefox 45.0.2 is different from the latest release (46 and latter). Infact the Gtk is not only causing this issue, it is responsible for Bug 1275700 too. Probably we need to fix the Gtk behavior.

Comment 11

[:Gijs (he/him)]

Karl, do you know why we render a different background for -moz-appearance: menupopup when comparing gtk2 with gtk3? I think the relevant code is here: https://dxr.mozilla.org/mozilla-central/source/widget/gtk/gtk2drawing.c#2545-2564 and here: https://dxr.mozilla.org/mozilla-central/source/widget/gtk/gtk3drawing.cpp#2296-2318 but I don't know enough about gtk to decipher that.

Comment 12

[Karl Tomlinson (:karlt)]

(In reply to :Gijs Kruitbosch from comment #11)
> Karl, do you know why we render a different background for -moz-appearance:
> menupopup when comparing gtk2 with gtk3?

-moz-appearance:menupopup draws the background using the gtk theme in use on the system.  GTK2 and GTK3 do not share the same interface with different themes, and so themes are written differently for GTK2 and GTK3.  Although some GTK2 versions of themes may use similar colors to a corresponding GTK3 theme, attachment 8746505 [details] shows this is not the case for popup menus with the default themes on Ubuntu 14.04.

If using -moz-appearance:menupopup for the background, then I would recommend
using -moz-appearance:menuitem for the menu items.

However, it may be preferable to style the submenu consistently with the
doorhanger.

Comment 13

[:Gijs (he/him)]

Attachment: Bug 1268462 - match main popup appearance in bookmarks toolbar submenus,

Review commit: https://reviewboard.mozilla.org/r/58944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58944/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/151500c01e44
match main popup appearance in bookmarks toolbar submenus, r=dao

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/151500c01e44

Comment 16

[Alice0775 White]

I can confirm that the problem was fixed.

https://hg.mozilla.org/mozilla-central/rev/016e0f47e8ad66ba6eb11fe28958e3a69ef9e53d
Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0 ID:20160612030220

Comment 17

[:Gijs (he/him)]

Comment on attachment 8762006 [details]
Bug 1268462 - match main popup appearance in bookmarks toolbar submenus,

Approval Request Comment
[Feature/regressing bug #]: switch to gtk3
[User impact if declined]: submenus in the bookmarks toolbar popup are unreadable under some gtk3 themes
[Describe test coverage new/current, TreeHerder]: nope, appearance problem only
[Risks and why]: relatively low, CSS only changes to the linux browser theme
[String/UUID change made/needed]: nope

Comment 18

[Gerry Chang [:gchang]]

Comment on attachment 8762006 [details]
Bug 1268462 - match main popup appearance in bookmarks toolbar submenus,

Fix the regression issue of inconsistent submenu popup back ground color and it's verified. Take it in aurora & beta.

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/541035fe27cb

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/126e28e88202

Comment 21

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I managed to reproduce this bug using Fx 46.0 build ID:20160418114253 on Ubuntu 14.04.
Confirmed the fix on Fx 48.0b4, build ID 20160627144420 and Fx 49.0a2, build ID 20160630004007.