1269523 - Main menu items don't change their view after selecting (GTK3)

Status: RESOLVED DUPLICATE of bug 1248974

(Core :: Widget: Gtk, defect)

Description

[John Felton]

Attachment: gtk3-comparison-of-programs.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/49.0.2623.108 Chrome/49.0.2623.108 Safari/537.36

Steps to reproduce:

In my self-made theme on GTK3, the points in main menu don't change itself after selecting (GTK3). They don't change their highlighting, font color and borders.
Other programs on GTK3 work correct, like DeaDBeeF and Transmission.
For showing that's the problem is not in my theme, I made the screenshot of comparison these programs on GTK3.
--
OS: Lubuntu 16.04 x64.
I can give my theme if it's necessary.

Comment 1

[Karl Tomlinson (:karlt)]

Can you paste the CSS specific to highlighting the menuitems, please?

What version of GTK are you testing with?

Comment 2

[Martin Stránský [:stransky] (ni? me)]

(In reply to Karl Tomlinson (ni?:karlt) from comment #1)
> Can you paste the CSS specific to highlighting the menuitems, please?
> 
> What version of GTK are you testing with?

Karl, I believe that's a general problem and it's caused by gtk style save we use on the menuitem, when it looses the hover state.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

We need to remove gtk_style_context_save() from moz_gtk_menu_item_paint() and also adjust text color for the menu. I'll try to create a patch for it.

Comment 4

[John Felton]

(In reply to Karl Tomlinson (ni?:karlt) from comment #1)
> Can you paste the CSS specific to highlighting the menuitems, please?
> 
> What version of GTK are you testing with?

OS: Lubuntu 16.04, GTK 3.18.
I attached my theme (gtk3-theme.zip) for helping developers.

Comment 5

[John Felton]

Attachment: gtk3-theme.zip

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Looks like a dupe of 1248974.