Closed Bug 1268483 Opened 4 years ago Closed 4 years ago

Red square present over hamburger button when completing a download while Downloads icons is placed in Panel Menu

Categories

(Firefox :: Downloads Panel, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 49
Iteration:
49.1 - May 9
Tracking Status
firefox46 --- unaffected
firefox47 --- unaffected
firefox48 + verified
firefox49 --- verified

People

(Reporter: bogdan_maris, Assigned: past)

References

Details

(Keywords: regression, Whiteboard: [fxprivacy])

Attachments

(2 files)

[Affected versions]:
- latest Developer Edition 48.0a2
- latest Nightly 49.0a1

[Affected platforms]:
- Mac OS X 10.10.5
- Ubuntu 12.04 32-bit
- Windows 10 64-bit

[Steps to reproduce]:
1. Start Firefox
2. Move Downloads icon to panel menu
3. Download a sample file (I used http://www.thinkbroadband.com/download/)

[Expected result]:
- A short animation is displayed notifying the user that a download was successfully made.

[Actual result]:
- A red square shows up over hamburger button when completing a download.

[Regression range]:
- Mozregression output:

m-i:

Last good revision: fc15477ce628599519cb0055f52cc195d640dc94
First bad revision: 37f04460ddb76d6ef4e7c32a8a6b2fbc44cb8776
Pushlog: 
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fc15477ce628599519cb0055f52cc195d640dc94&tochange=37f04460ddb76d6ef4e7c32a8a6b2fbc44cb8776

Potential bugs affecting this:
a36e52a4543d	Paolo Amadini — Bug 1265358 - Enable blocking of uncommon downloads. r=gcp
f36212ee8d4a	Paolo Amadini — Bug 1265359 - Enable blocking of potentially unwanted downloads. r=gcp

[Additional notes]:
- Screenshot added showing the issue.
Flags: needinfo?(paolo.mozmail)
[Tracking Requested - why for this release]:
Highly user-visible regression.
Flags: needinfo?(paolo.mozmail) → needinfo?(past)
This is probably my fault, I'll take it once I'm back from training.
Assignee: nobody → past
Status: NEW → ASSIGNED
Flags: needinfo?(past)
Priority: -- → P1
Whiteboard: [fxprivacy]
Whiteboard: [fxprivacy] → [fxprivacy] [triage]
Iteration: --- → 49.1 - May 9
Flags: qe-verify?
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Flags: qe-verify? → qe-verify+
Comment on attachment 8749725 [details]
MozReview Request: Don't show a badge on the hamburger button for successful downloads (bug 1268483). r?jaws

https://reviewboard.mozilla.org/r/51131/#review47825
https://hg.mozilla.org/mozilla-central/rev/1d32762a2035
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment on attachment 8749725 [details]
MozReview Request: Don't show a badge on the hamburger button for successful downloads (bug 1268483). r?jaws

Approval Request Comment
[Feature/regressing bug #]: bug 1139472
[User impact if declined]: successful downloads for users who have moved the downloads button inside the menu panel will display a weird red square on the menu button
[Describe test coverage new/current, TreeHerder]: just manual testing
[Risks and why]: tiny risk, CSS-only change
[String/UUID change made/needed]: none
Attachment #8749725 - Flags: approval-mozilla-aurora?
Blocks: 1216897
Recent regression, tracking.
Comment on attachment 8749725 [details]
MozReview Request: Don't show a badge on the hamburger button for successful downloads (bug 1268483). r?jaws

UI fix, just css, should be fine on aurora.
Attachment #8749725 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(for QE) Please verify this on aurora once it lands rather than on nightly. Thanks!
Verified using latest Nightly 49.0a1 and latest Developer Edition 48.0a2 that the issue is no longer reproducible across platforms (Windows 7 64-bit, Mac OS X 10.10.5 and Ubuntu 14.04 64-bit). 

I noticed though that on the first download (new profile) there is no warning that a download has finished (following steps from comment 0). After download manager was opened once, a slight transition is present letting me know that I downloaded something. This is reproducible across all builds: 46, 47, 48, 49. I have a feeling this is a known issue but did not found a bug related to this.
Status: RESOLVED → VERIFIED
Flags: qe-verify+ → needinfo?(past)
I'm pretty sure it is known, yes. You might just file a new bug and we'll mark it as duplicate when we find it.
Flags: needinfo?(past)
You need to log in before you can comment on or make changes to this bug.