1268744 - Firebug theme - Should use filter.svg instead of magnifying-glass-light.png in the searchBox

Status: RESOLVED FIXED

(DevTools :: DOM, enhancement, P2)

Description

[magicp]

Attachment: background-image-of-searchBox.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160428030218

Steps to reproduce:

1. Start Nightly
2. Go to any sites (e.g. about:home)
3. Open DevTools > DOM with Firebug theme
4. Confirm searchBox


Actual results:

Using "chrome://devtools/skin/images/magnifying-glass-light.png" as background-image of searchBox.


Expected results:

Should use "chrome://devtools/skin/images/firebug/filter.svg"

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yes, this should be fixed.

Honza

Comment 2

[Sebastian Zartner [:sebo]]

Just checked this in Nightly 53.0a1 (2016-12-24) and this is not fixed yet.

Sebastian

Comment 3

[Sebastian Zartner [:sebo]]

Attachment: Comparison between DevTools and Firebug

Here's a comparison between Firebug's and the DevTools icon.

Sebastian

Comment 4

[Tim Nguyen :ntim]

(In reply to Sebastian Zartner [:sebo] from comment #3)
> Created attachment 8821828 [details]
> Comparison between DevTools and Firebug
> 
> Here's a comparison between Firebug's and the DevTools icon.
> 
> Sebastian
That's a different issue, this bug is about the DOM panel not using the filter icon, but the search icon.

Also, I remember Honza agreed on IRC to drop the Firebug theme specific images for filter and search inputs when I had asked him for bug 1285747. However, if you feel strongly about the previous icons, feel free to file a bug.

Comment 5

[Sebastian Zartner [:sebo]]

(In reply to Tim Nguyen :ntim (use needinfo?) from comment #4)
> (In reply to Sebastian Zartner [:sebo] from comment #3)
> > Created attachment 8821828 [details]
> > Comparison between DevTools and Firebug
> > 
> > Here's a comparison between Firebug's and the DevTools icon.
> > 
> > Sebastian
> That's a different issue, this bug is about the DOM panel not using the
> filter icon, but the search icon.

Oh, you're right. I'm sorry, I totally missed that!

> Also, I remember Honza agreed on IRC to drop the Firebug theme specific
> images for filter and search inputs when I had asked him for bug 1285747.
> However, if you feel strongly about the previous icons, feel free to file a
> bug.

I filed bug 1326527 for that, because I believe the icons don't fit well to the Firebug theme. And it should be easy to replace them.

Sebastian