1263889 - (improve-fb-theme) [meta] Firebug Theme Improvements

Status: RESOLVED WONTFIX

(DevTools :: General, enhancement, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is a follow up for bug 1244054

Suggested improvements for Firebug theme:
* Toolbar backgrounds should be specified using CSS variables.
* Splitters: the main Toolbox splitter (horizontal) can't be themed since it's outside the Toolbox and can't utilize root element theme class. All the other splitters should be 5px wide/tall in Firebug theme. But make sure they are not visible when side bars are hidden.
* Black list of non-inverted icons. Do not use  --icon-filter: none; for all images in Firebug theme (toolbars.css)
* Modifying image of #toolbox-tab-options is hacky (it's because the image is hardcoded in Options tool definition (definitions.js)
* RTL should be properly tested (e.g. debugger tab highlighted icon should be on the right for RTL)
* --proportional-font-family for Firebug theme is needed?
* Better way to customize code mirror colors
* We should have a global solution for all tools that have a highlighted icon state (memory, performance and debugger).
* Move Firebug theme support for console.table() into widgets.css
* Highlighter colors should match Firebug's colors (bug 1128209 maybe related)

This is a meta bug and patches should go to further reports

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Autocomplete-popup.js is generating class-name from a value coming from 'devtools.theme' pref. This logic doesn't take in account that some themes can use more class names. It should get value from the theme definition.classList

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Inspector breadcrumbs path should support RTL.

Honza

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The Firebug theme is appending "()" after function name in the Stack (side) panel.
It's using content: "()", which is hacky. We might want to do this in JS and perhaps for every theme.

Honza

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

> * Move Firebug theme support for console.table() into widgets.css
This has been done as part for bug 1244054

Honza

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Feedback from Helen:
(see also: https://bugzilla.mozilla.org/show_bug.cgi?id=1244054#c97)

- Sometimes the tab looks odd with the background because of the contents of the pane. (See screenshot: http://cl.ly/3c2c1B1A2G2W) Tools with a secondary toolbar don’t seem to have this problem. Temporary fix below:
- Man, the command buttons look strange with Firebug. (http://cl.ly/310Z211R1I12) unsure what to do about that right now.
- I also notice that the Settings cog is sitting a little low: http://cl.ly/310Z211R1I12 That might be regular theme CSS messing with Firebug CSS.
- The command-pick, on the other hand, looks a little high: http://cl.ly/261I1c3j411X 

Honza

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Jan Honza Odvarko [:Honza] from comment #5)
> Feedback from Helen:
> - Man, the command buttons look strange with Firebug.
> (http://cl.ly/310Z211R1I12) unsure what to do about that right now.
There is now bug 1265985 covering this.

Honza

Comment 7

[Tim Nguyen :ntim]

Other firebug theme bugs that might not block this bug: https://bugzilla.mozilla.org/buglist.cgi?f1=blocked&list_id=12988996&short_desc=firebug%20theme&o1=notsubstring&resolution=---&query_format=advanced&short_desc_type=allwordssubstr&v1=1263889

Comment 8

[Ruturaj Vartak]

Would Bug#1314919 also block / link to this meta-bug ?

Comment 9

[Patrick Brosset <:pbro>]

DevTools bug triage (filter on CLIMBING SHOES).

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The Firebug theme was removed in Bug 1378108, so I am marking this meta as WONTFIX.

Honza