Bug 1263889 (improve-fb-theme)

[meta] Firebug Theme Improvements

RESOLVED WONTFIX

Status

()

Firefox
Developer Tools
P3
enhancement
RESOLVED WONTFIX
2 years ago
a month ago

People

(Reporter: Honza, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
This is a follow up for bug 1244054

Suggested improvements for Firebug theme:
* Toolbar backgrounds should be specified using CSS variables.
* Splitters: the main Toolbox splitter (horizontal) can't be themed since it's outside the Toolbox and can't utilize root element theme class. All the other splitters should be 5px wide/tall in Firebug theme. But make sure they are not visible when side bars are hidden.
* Black list of non-inverted icons. Do not use  --icon-filter: none; for all images in Firebug theme (toolbars.css)
* Modifying image of #toolbox-tab-options is hacky (it's because the image is hardcoded in Options tool definition (definitions.js)
* RTL should be properly tested (e.g. debugger tab highlighted icon should be on the right for RTL)
* --proportional-font-family for Firebug theme is needed?
* Better way to customize code mirror colors
* We should have a global solution for all tools that have a highlighted icon state (memory, performance and debugger).
* Move Firebug theme support for console.table() into widgets.css
* Highlighter colors should match Firebug's colors (bug 1128209 maybe related)

This is a meta bug and patches should go to further reports

Honza
(Reporter)

Updated

2 years ago
Depends on: 1244054
Severity: normal → enhancement
(Reporter)

Comment 1

2 years ago
Autocomplete-popup.js is generating class-name from a value coming from 'devtools.theme' pref. This logic doesn't take in account that some themes can use more class names. It should get value from the theme definition.classList

Honza
(Reporter)

Comment 2

2 years ago
Inspector breadcrumbs path should support RTL.

Honza
(Reporter)

Comment 3

2 years ago
The Firebug theme is appending "()" after function name in the Stack (side) panel.
It's using content: "()", which is hacky. We might want to do this in JS and perhaps for every theme.

Honza
(Reporter)

Comment 4

2 years ago
> * Move Firebug theme support for console.table() into widgets.css
This has been done as part for bug 1244054

Honza
(Reporter)

Updated

2 years ago
Depends on: 1264312
(Reporter)

Comment 5

2 years ago
Feedback from Helen:
(see also: https://bugzilla.mozilla.org/show_bug.cgi?id=1244054#c97)

- Sometimes the tab looks odd with the background because of the contents of the pane. (See screenshot: http://cl.ly/3c2c1B1A2G2W) Tools with a secondary toolbar don’t seem to have this problem. Temporary fix below:
- Man, the command buttons look strange with Firebug. (http://cl.ly/310Z211R1I12) unsure what to do about that right now.
- I also notice that the Settings cog is sitting a little low: http://cl.ly/310Z211R1I12 That might be regular theme CSS messing with Firebug CSS.
- The command-pick, on the other hand, looks a little high: http://cl.ly/261I1c3j411X 

Honza
(Reporter)

Updated

2 years ago
Depends on: 1265985
(Reporter)

Comment 6

2 years ago
(In reply to Jan Honza Odvarko [:Honza] from comment #5)
> Feedback from Helen:
> - Man, the command buttons look strange with Firebug.
> (http://cl.ly/310Z211R1I12) unsure what to do about that right now.
There is now bug 1265985 covering this.

Honza
(Reporter)

Updated

2 years ago
Summary: Firebug Theme Improvements → [meta] Firebug Theme Improvements
(Reporter)

Updated

2 years ago
Depends on: 1266021

Updated

2 years ago
Alias: improve-fb-theme

Updated

2 years ago
Depends on: 1266300

Updated

2 years ago
Depends on: 1266305

Updated

2 years ago
Depends on: 1266306

Updated

2 years ago
Depends on: 1266308

Updated

2 years ago
Depends on: 1266310
(Reporter)

Updated

2 years ago
Depends on: 1266716
Depends on: 1266733
(Reporter)

Updated

2 years ago
Depends on: 1267274

Updated

2 years ago
No longer depends on: 1266305, 1266306, 1266308

Updated

2 years ago
Depends on: 1268171

Updated

2 years ago
Depends on: 1268188

Updated

2 years ago
Depends on: 1267788

Updated

2 years ago
Depends on: 1267802

Updated

2 years ago
Depends on: 1153681

Updated

2 years ago
Depends on: 1268494

Updated

2 years ago
Depends on: 1268495

Updated

2 years ago
Depends on: 1268591
(Reporter)

Updated

2 years ago
Depends on: 1268744
Depends on: 1269720
Depends on: 1269724
Depends on: 1269726
Depends on: 1269730

Updated

2 years ago
Depends on: 1268738

Updated

2 years ago
Depends on: 1279703

Updated

2 years ago
Depends on: 1280791
Depends on: 1285449

Updated

2 years ago
Depends on: 1288209
Depends on: 1306139
Depends on: 1318259
Depends on: 1326527

Comment 8

a year ago
Would Bug#1314919 also block / link to this meta-bug ?
Depends on: 1308940

Updated

a year ago
Depends on: 1314919
DevTools bug triage (filter on CLIMBING SHOES).
Priority: -- → P3
(Reporter)

Comment 10

a month ago
The Firebug theme was removed in Bug 1378108, so I am marking this meta as WONTFIX.

Honza
Status: NEW → RESOLVED
Last Resolved: a month ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.