Closed Bug 1268837 Opened 8 years ago Closed 8 years ago

[e10s] screenshot --chrome only captures chrome

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P1)

Product:
DevTools Graveyard
Component:
Graphic Commandline and Toolbar
Platform:
x86
Windows 7
Type:
defect

Tracking

(e10s+, firefox50 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 50
Tracking Flags:
Tracking Status
e10s + ---
firefox50 --- fixed

People

(Reporter: elbart, Assigned: miker)

References

(
URL
)

Details

Attachments

(2 files, 1 obsolete file)

moz-chrome.png
21.12 KB, image/png
Details
1268837-remove-screenshot---chrome.diff
10.40 KB, patch
miker
: review+
Details | Diff | Splinter Review
Attached image moz-chrome.png — 
+++ This bug was initially created as a clone of Bug #1268834 +++

Windows 7
Nightly as of yesterday/today
> screenshot ---chrome file.png

The content-area comes up empty in e10s.
Blocks: e10s
My gut reaction is that this could be tricky to fix - stitching together 2 screenshots smells like it's going to be buggy. I'm tempted to just remove that option.
Priority: -- → P1
Assignee: nobody → mratcliffe
Sorry to ask you for review Joe but GCLI is yours.

I completely agree, the moment we begin stitching images together memory usage is going to sky rocket and we have a fertile environment for timeouts and crashes... a rabbit hole best avoided.

This simple patch removes the --chrome option.
Attachment #8766409 - Flags: review?(jwalker)
Comment on attachment 8766409 [details] [diff] [review]
1268837-remove-screenshot---chrome.diff

Review of attachment 8766409 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks.
Attachment #8766409 - Flags: review?(jwalker) → review+
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
has problems to apply:

patching file devtools/shared/gcli/commands/screenshot.js
Hunk #2 FAILED at 173
1 out of 2 hunks FAILED -- saving rejects to file devtools/shared/gcli/commands/screenshot.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 1268837-remove-screenshot---chrome.diff
Flags: needinfo?(mratcliffe)
Keywords: checkin-needed
Rebased.
Attachment #8766409 - Attachment is obsolete: true
Flags: needinfo?(mratcliffe)
Attachment #8766762 - Flags: review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/de6b42bae9dd
Remove GCLI screenshot --chrome file.png. r=jwalker
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/de6b42bae9dd
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: