1268837 - [e10s] screenshot --chrome only captures chrome

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P1)

Description

[Elbart]

Attachment: moz-chrome.png

+++ This bug was initially created as a clone of Bug #1268834 +++

Windows 7
Nightly as of yesterday/today
> screenshot ---chrome file.png

The content-area comes up empty in e10s.

Comment 1

[Joe Walker [:jwalker]]

My gut reaction is that this could be tricky to fix - stitching together 2 screenshots smells like it's going to be buggy. I'm tempted to just remove that option.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: 1268837-remove-screenshot---chrome.diff

Sorry to ask you for review Joe but GCLI is yours.

I completely agree, the moment we begin stitching images together memory usage is going to sky rocket and we have a fertile environment for timeouts and crashes... a rabbit hole best avoided.

This simple patch removes the --chrome option.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44ac7f6e9815

Comment 5

[Joe Walker [:jwalker]]

Comment on attachment 8766409 [details] [diff] [review]
1268837-remove-screenshot---chrome.diff

Review of attachment 8766409 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks.

Comment 6

[Carsten Book [:Tomcat]]

has problems to apply:

patching file devtools/shared/gcli/commands/screenshot.js
Hunk #2 FAILED at 173
1 out of 2 hunks FAILED -- saving rejects to file devtools/shared/gcli/commands/screenshot.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 1268837-remove-screenshot---chrome.diff

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: 1268837-remove-screenshot---chrome.diff

Rebased.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/de6b42bae9dd
Remove GCLI screenshot --chrome file.png. r=jwalker

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/de6b42bae9dd